chore: upgrade to typescript@4
#650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Linting breaks because of changes to tuples in TS, which was fixed in typescript-eslint/typescript-eslint#2197 but I'm guessing was released in v3 :( |
G-Rath
force-pushed
the
update-to-typescript-4
branch
from
0f9f600
to
37914cb
Compare
What do you mean? CI seems happy? |
|
That's because I changed the base branch to Check out this action run. |
|
Aha, right! Should we wait for official v4 support (typescript-eslint/typescript-eslint#2260 (comment))? |
SimenB
pushed a commit
that referenced
this pull request
Aug 24, 2020
SimenB
pushed a commit
that referenced
this pull request
Aug 24, 2020
SimenB
pushed a commit
that referenced
this pull request
Aug 31, 2020
SimenB
pushed a commit
that referenced
this pull request
Sep 4, 2020
SimenB
pushed a commit
that referenced
this pull request
Sep 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
no-focused-testscould probably use a rewrite using the utils, but it works so 馃し