Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unneeded checks #638

Merged
merged 4 commits into from Aug 2, 2020
Merged

Remove unneeded checks #638

merged 4 commits into from Aug 2, 2020

Conversation

G-Rath
Copy link
Collaborator

@G-Rath G-Rath commented Aug 2, 2020

Spotted this while doing #637 - it's impossible to craft an AST tree where a Node is both an ExpectMember & does not have a parent.

Also found a few conditions that can be simplified using optional chaining 馃帀

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One q, otherwise 馃憤

src/rules/valid-expect.ts Outdated Show resolved Hide resolved
@G-Rath G-Rath merged commit 660bc99 into master Aug 2, 2020
@G-Rath G-Rath deleted the remove-unneeded-checks branch August 2, 2020 11:10
@github-actions
Copy link

github-actions bot commented Sep 4, 2020

馃帀 This PR is included in version 24.0.0 馃帀

The release is available on:

Your semantic-release bot 馃摝馃殌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants