feat: import formatting rules from eslint-plugin-jest-formatting
#1563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
G-Rath
force-pushed
the
import-formatting
branch
from
025ebb2
to
e8ea5eb
Compare
github-actions
bot
added
bug
rule: padding-around-before-all-blocks
rule: padding-around-test-blocks
rule: padding-around-after-all-blocks
rule: padding-around-all
rule: padding-around-before-each-blocks
rule: padding-around-after-each-blocks
rule: padding-around-describe-blocks
rule: padding-around-expect-groups
enhancement
labels
G-Rath
force-pushed
the
import-formatting
branch
2 times, most recently
from
d8b49bd
to
f987cb6
Compare
|
Note that for now I've focused on integrating the rules into our plugin with as minimal changes as possible - there's a few things I'd like to explore refactoring, but I've not found anything actually horribly broken so I think it's better to leave such refactors for a follow-up (or at least for after confirming we want to land this); likewise for adding any new configs. |
G-Rath
force-pushed
the
import-formatting
branch
2 times, most recently
from
066223d
to
b6d8241
Compare
G-Rath
force-pushed
the
import-formatting
branch
from
b6d8241
to
df85861
Compare
SimenB
approved these changes
May 2, 2024
|
@dangreenisrael are you happy for this to happen? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This explores what it would be like to import the formatting rules from
eslint-plugin-jest-formatting- I'm a big fan of these rules and have always thought it would make sense to include them as I don't think this is a particularly controversial style.Related: dangreenisrael/eslint-plugin-jest-formatting#122