Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add should-be-fine support for flat configs #1505

Merged
merged 7 commits into from
Feb 16, 2024
Merged

Conversation

G-Rath
Copy link
Collaborator

@G-Rath G-Rath commented Feb 16, 2024

This has gone in an alternative direction to #1503 that is based on how eslint-plugin-jsdoc is doing flat configs, and feels a lot simpler - it didn't archive my actual goal of making our configs static, but I'll do that in a follow up.

Also it's a little bit messy because our version of @typescript-eslint doesn't support flat config but that'll improve once we upgrade as well the structure.

I've tested this against a codebase and it seems to work fine 🤷

Resolves #1408
Closes #1503

@G-Rath G-Rath removed the bug label Feb 16, 2024
@G-Rath G-Rath merged commit 4cc2a1b into main Feb 16, 2024
42 checks passed
@G-Rath G-Rath deleted the support-flat-config2 branch February 16, 2024 17:37
github-actions bot pushed a commit that referenced this pull request Feb 16, 2024
# [27.9.0](v27.8.0...v27.9.0) (2024-02-16)

### Features

* add should-be-fine support for flat configs ([#1505](#1505)) ([4cc2a1b](4cc2a1b))
Copy link

🎉 This PR is included in version 27.9.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support ESLint "flat" configs
2 participants