Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): update dependency eslint-plugin-eslint-plugin to v5 #1165

Merged
merged 2 commits into from Jul 13, 2022
Merged

chore(deps): update dependency eslint-plugin-eslint-plugin to v5 #1165

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
af89442
chore(deps): update dependency eslint-plugin-eslint-plugin to v5
renovate[bot] Jul 12, 2022
d05a224
chore: ignore false positives from eslint
G-Rath Jul 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Expand Up @@ -104,7 +104,7 @@
"eslint-config-prettier": "^8.3.0",
"eslint-plugin-eslint-comments": "^3.1.2",
"eslint-plugin-eslint-config": "^2.0.0",
"eslint-plugin-eslint-plugin": "^4.0.1",
"eslint-plugin-eslint-plugin": "^5.0.0",
"eslint-plugin-import": "^2.25.1",
"eslint-plugin-node": "^11.0.0",
"eslint-plugin-prettier": "^3.4.1",
Expand Down
2 changes: 2 additions & 0 deletions src/rules/unbound-method.ts
View file
Open in desktop
Expand Up @@ -68,7 +68,9 @@ export default createRule<Options, MessageIds>({
name: __filename,
meta: {
messages: {
// eslint-disable-next-line eslint-plugin/no-unused-message-ids
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we report a bug?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Na these are being used by the base rule but we need to define them here to make TypeScript happy since it relates to what IDs we can use in the tests (they actually get overridden if the base rule exists).

I wouldn't expect the plugin to try and figure that out

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#1196

eslint-community/eslint-plugin-eslint-plugin#290

unbound: DEFAULT_MESSAGE,
// eslint-disable-next-line eslint-plugin/no-unused-message-ids
unboundWithoutThisAnnotation: DEFAULT_MESSAGE,
},
schema: [],
Expand Down
12 changes: 6 additions & 6 deletions yarn.lock
View file
Open in desktop
Expand Up @@ -4368,15 +4368,15 @@ __metadata:
languageName: node
linkType: hard

"eslint-plugin-eslint-plugin@npm:^4.0.1":
version: 4.4.0
resolution: "eslint-plugin-eslint-plugin@npm:4.4.0"
"eslint-plugin-eslint-plugin@npm:^5.0.0":
version: 5.0.0
resolution: "eslint-plugin-eslint-plugin@npm:5.0.0"
dependencies:
eslint-utils: ^3.0.0
estraverse: ^5.2.0
peerDependencies:
eslint: ">=6.0.0"
checksum: 3ae989d54f035197b1d3c3a893dbeb2a8bf474a723bd861991b33dff9fd591c322487e4eb61d2bbab0aac9bea8e27f28c834d544ee6c745343f8a4b6bb6b0a06
eslint: ">=7.0.0"
checksum: 9166280af1676b29ed78877c81c74bb0ac582df8b38984985d9cc9852b217eaab6528cbda77358a4660b7e15eb60a44e76306223e14bc42598f8cbfdde7ae098
languageName: node
linkType: hard

Expand Down Expand Up @@ -4430,7 +4430,7 @@ __metadata:
eslint-config-prettier: ^8.3.0
eslint-plugin-eslint-comments: ^3.1.2
eslint-plugin-eslint-config: ^2.0.0
eslint-plugin-eslint-plugin: ^4.0.1
eslint-plugin-eslint-plugin: ^5.0.0
eslint-plugin-import: ^2.25.1
eslint-plugin-node: ^11.0.0
eslint-plugin-prettier: ^3.4.1
Expand Down