fix(require-hook): check variables are either const or declarations

jest-community · Oct 16, 2021 · cb52383 · cb52383
1 parent 5278fcb
commit cb52383
Show file tree

Hide file tree

Showing 2 changed files with 53 additions and 0 deletions.
diff --git a/src/rules/__tests__/require-hook.test.ts b/src/rules/__tests__/require-hook.test.ts
@@ -176,6 +176,47 @@ ruleTester.run('require-hook', rule, {
         },
       ],
     },
+    {
+      code: dedent`
+        let consoleErrorSpy = jest.spyOn(console, 'error');
+
+        describe('when loading cities from the api', () => {
+          let consoleWarnSpy = jest.spyOn(console, 'warn');
+        });
+      `,
+      errors: [
+        {
+          messageId: 'useHook',
+          line: 1,
+          column: 1,
+        },
+        {
+          messageId: 'useHook',
+          line: 4,
+          column: 3,
+        },
+      ],
+    },
+    {
+      code: "let consoleErrorSpy, consoleWarnSpy = jest.spyOn(console, 'error');",
+      errors: [
+        {
+          messageId: 'useHook',
+          line: 1,
+          column: 1,
+        },
+      ],
+    },
+    {
+      code: "let consoleErrorSpy = jest.spyOn(console, 'error'), consoleWarnSpy;",
+      errors: [
+        {
+          messageId: 'useHook',
+          line: 1,
+          column: 1,
+        },
+      ],
+    },
     {
       code: dedent`
         import { database, isCity } from '../database';
@@ -236,6 +277,11 @@ ruleTester.run('require-hook', rule, {
           line: 16,
           column: 1,
         },
+        {
+          messageId: 'useHook',
+          line: 31,
+          column: 3,
+        },
         {
           messageId: 'useHook',
           line: 33,

diff --git a/src/rules/require-hook.ts b/src/rules/require-hook.ts
@@ -25,6 +25,13 @@ const shouldBeInHook = (node: TSESTree.Node): boolean => {
       return shouldBeInHook(node.expression);
     case AST_NODE_TYPES.CallExpression:
       return !isJestFnCall(node);
+    case AST_NODE_TYPES.VariableDeclaration: {
+      if (node.kind === 'const') {
+        return false;
+      }
+
+      return node.declarations.some(({ init }) => init !== null);
+    }
 
     default:
       return false;