fix(no-restricted-matchers): allow restricting negated resolves and…

… `rejects` modifiers
jest-community · Jun 4, 2022 · bba5108 · bba5108
1 parent 8f567b1
commit bba5108
Show file tree

Hide file tree

Showing 2 changed files with 58 additions and 2 deletions.
diff --git a/src/rules/__tests__/no-restricted-matchers.test.ts b/src/rules/__tests__/no-restricted-matchers.test.ts
@@ -99,6 +99,36 @@ ruleTester.run('no-restricted-matchers', rule, {
         },
       ],
     },
+    {
+      code: 'expect(a).resolves.toBe(b)',
+      options: [{ resolves: null }],
+      errors: [
+        {
+          messageId: 'restrictedChain',
+          data: {
+            message: null,
+            chain: 'resolves',
+          },
+          column: 11,
+          line: 1,
+        },
+      ],
+    },
+    {
+      code: 'expect(a).resolves.not.toBe(b)',
+      options: [{ 'resolves.not': null }],
+      errors: [
+        {
+          messageId: 'restrictedChain',
+          data: {
+            message: null,
+            chain: 'resolves.not',
+          },
+          column: 11,
+          line: 1,
+        },
+      ],
+    },
     {
       code: 'expect(a).not.toBe(b)',
       options: [{ 'not.toBe': null }],
@@ -115,6 +145,22 @@ ruleTester.run('no-restricted-matchers', rule, {
         },
       ],
     },
+    {
+      code: 'expect(a).resolves.not.toBe(b)',
+      options: [{ 'resolves.not.toBe': null }],
+      errors: [
+        {
+          messageId: 'restrictedChain',
+          data: {
+            message: null,
+            chain: 'resolves.not.toBe',
+          },
+          endColumn: 28,
+          column: 11,
+          line: 1,
+        },
+      ],
+    },
     {
       code: 'expect(a).toBe(b)',
       options: [{ toBe: 'Prefer `toStrictEqual` instead' }],

diff --git a/src/rules/no-restricted-matchers.ts b/src/rules/no-restricted-matchers.ts
@@ -54,7 +54,11 @@ export default createRule<
         }
 
         if (modifier) {
-          const chain = modifier.name;
+          let chain: string = modifier.name;
+
+          if (modifier.negation) {
+            chain += '.not';
+          }
 
           if (chain in restrictedChains) {
             const message = restrictedChains[chain];
@@ -72,7 +76,13 @@ export default createRule<
         }
 
         if (matcher && modifier) {
-          const chain = `${modifier.name}.${matcher.name}`;
+          let chain: string = modifier.name;
+
+          if (modifier.negation) {
+            chain += '.not';
+          }
+
+          chain += `.${matcher.name}`;
 
           if (chain in restrictedChains) {
             const message = restrictedChains[chain];