chore(valid-expect): swap early return for smaller body

jest-community · Aug 6, 2019 · 405b2e8 · 405b2e8
1 parent decfabb
commit 405b2e8
Showing 1 changed file with 3 additions and 8 deletions.
diff --git a/src/rules/valid-expect.ts b/src/rules/valid-expect.ts
@@ -281,16 +281,11 @@ export default createRule<[{ alwaysAwait?: boolean }], MessageIds>({
       // nothing called on "expect()"
       'CallExpression:exit'(node: TSESTree.CallExpression) {
         if (
-          !isExpectCall(node) ||
-          node.parent.type !== AST_NODE_TYPES.ExpressionStatement
+          isExpectCall(node) &&
+          node.parent.type === AST_NODE_TYPES.ExpressionStatement
         ) {
-          return;
+          context.report({ messageId: 'noAssertions', node });
         }
-
-        context.report({
-          messageId: 'noAssertions',
-          node,
-        });
       },
     };
   },