chore(lint): update linting rules (#351)

.eslintrc.js

@@ -25,6 +25,10 @@ module.exports = {
     es6: true,
   },
   rules: {
+    '@typescript-eslint/array-type': ['error', 'array-simple'],
+    '@typescript-eslint/no-require-imports': 'error',
+    '@typescript-eslint/ban-ts-ignore': 'warn',
+    'no-else-return': 'error',
     eqeqeq: ['error', 'smart'],
     strict: 'error',
     'prefer-template': 'warn',
@@ -42,6 +46,12 @@ module.exports = {
     'import/no-extraneous-dependencies': 'error',
   },
   overrides: [
+    {
+      files: ['*.js'],
+      rules: {
+        '@typescript-eslint/no-require-imports': 'off',
+      },
+    },
     {
       files: ['*.test.js', '*.test.ts'],
       globals,
@@ -55,6 +65,7 @@ module.exports = {
     {
       files: ['.eslintrc.js', 'babel.config.js'],
       rules: {
+        '@typescript-eslint/no-require-imports': 'off',
         'import/no-commonjs': 'off',
       },
     },

src/rules/no-if.ts

@@ -34,7 +34,7 @@ export default createRule({
   },
   defaultOptions: [],
   create(context) {
-    const stack: Array<boolean> = [];
+    const stack: boolean[] = [];
 
     function validate(
       node: TSESTree.ConditionalExpression | TSESTree.IfStatement,

src/rules/no-large-snapshots.js

@@ -35,9 +35,8 @@ const reportOnViolation = (context, node) => {
       isWhitelisted = whitelistedSnapshotsInFile.some(name => {
         if (name.test && typeof name.test === 'function') {
           return name.test(snapshotName);
-        } else {
-          return name === snapshotName;
         }
+        return name === snapshotName;
       });
     }
   }

src/rules/valid-expect-in-promise.js

@@ -14,9 +14,8 @@ const isExpectCallPresentInFunction = body => {
         return isExpectCall(line.expression);
       if (line.type === 'ReturnStatement') return isExpectCall(line.argument);
     });
-  } else {
-    return isExpectCall(body);
   }
+  return isExpectCall(body);
 };
 
 const isExpectCall = expression => {