Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more babel configuration file format and replace babel icon #543

Merged
merged 3 commits into from Mar 12, 2020

Conversation

JLHwung
Copy link
Contributor

@JLHwung JLHwung commented Oct 25, 2019

In this PR we add more babel configuration file formats, including those supported in the upcoming Babel 7.7.

We also replace the out-of-dated 6to5 logo by the new Babel logo, the resource can be found in babel/website#2028 (comment)

Todo

  • rebuild the font.

@JLHwung JLHwung changed the title Add more babel configuration Add more babel configuration file format and replace babel icon Oct 25, 2019
@orta
Copy link
Collaborator

orta commented Oct 25, 2019

Yeah, this makes sense to me - thanks.

It might be a bit large for the frame (looks like it fills the full 32x32 which most icons don't)

and being about 18 x 18 big

Any chance you can make it fit inside that sub-frame inside the 32x32, then we're good to go

@JLHwung
Copy link
Contributor Author

JLHwung commented Oct 25, 2019

@orta Unfortunately I don't get Illustrator or Sketch in hand. Could you help me resize it and push back to this branch? I am really appreciated.

Not related to this PR but I could not run gulp font due to gulpjs/gulp#2324
I could install an older node.js version after I get a faster Internet. But it would be great if we can update to gulp 4 since gulp 3 is no longer supported.

@orta
Copy link
Collaborator

orta commented Mar 12, 2020

Alright, I've revised the icon and pushed it up

@orta orta merged commit d59ccd0 into jesseweed:master Mar 12, 2020
@JLHwung JLHwung deleted the add-more-babel-configuration branch March 12, 2020 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants