Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make URLs in confirmation panels clickable, and underline them #3446

Merged
merged 5 commits into from Mar 29, 2024
Merged

Make URLs in confirmation panels clickable, and underline them #3446

merged 5 commits into from Mar 29, 2024

Commits on Mar 29, 2024

  1. Cleanup: don't mess with globals in tests without resetting them 

    Changing globals in the init() function of a test file is a bad idea, as it
affects all other tests that run after it. Do it explicitly in each test
function that needs it, and take care of restoring the previous value
afterwards.
    @stefanhaller
    stefanhaller committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    c59e6b6 View commit details
    Browse the repository at this point in the history

  2. Extract a function HandleGenericClick

    @stefanhaller
    stefanhaller committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    6396d1c View commit details
    Browse the repository at this point in the history

  3. Make HandleGenericClick a little smarter 

    Make it recognize URLs wrapped in angle brackets, and followed by punktuation.
We don't need this for the status panel, but we will need it for confirmation
panels.
    @stefanhaller
    stefanhaller committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    d102f12 View commit details
    Browse the repository at this point in the history

  4. Make links clickable in confirmation panels 

    This is not opt-in, we do it always. I can't imagine a situation where we
wouldn't want it.
    @stefanhaller
    stefanhaller committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    b9a75ee View commit details
    Browse the repository at this point in the history

  5. Underline links in confirmation panels

    @stefanhaller
    stefanhaller committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    5d509ef View commit details
    Browse the repository at this point in the history