Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: mouse events not working on some terminals #1713

Merged
merged 2 commits into from Jan 25, 2022
Merged

fix: mouse events not working on some terminals #1713

merged 2 commits into from Jan 25, 2022

Conversation

tmatz
Copy link
Contributor

@tmatz tmatz commented Jan 24, 2022

Mouse support is not working on crostini (chromebook linux virtual environment, ARM64).

It seems that, the fix is already merged to tcell upstream repository by gdamore/tcell#477

@jesseduffield
Copy link
Owner

@tmatz thanks for making this. Could we bump the version by using the go get -u command, and then use go mod vendor to persist the change?

@tmatz
Copy link
Contributor Author

tmatz commented Jan 24, 2022

@jesseduffield thank you! I'll try it.

@tmatz
Copy link
Contributor Author

tmatz commented Jan 24, 2022

tcell was still version 2.4.0 and did not contain a fix commit.

After updating all modules with go get -u, lazygit stopped working properly.

So I updated only tcell to the commit.

@jesseduffield
Copy link
Owner

Nice work! Merging

@jesseduffield jesseduffield merged commit b70075e into jesseduffield:master Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants