Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update bytes features with lasted bytes version 1.1.0 & add edition 2021 #12

Merged
merged 1 commit into from Feb 14, 2022
Merged

Update bytes features with lasted bytes version 1.1.0 & add edition 2021 #12

merged 1 commit into from Feb 14, 2022

Conversation

Stargateur
Copy link
Contributor

@Stargateur Stargateur commented Feb 9, 2022 •
edited

jeromefroe
jeromefroe reviewed Feb 13, 2022
View reviewed changes
Copy link
Owner

@jeromefroe jeromefroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just had one question on the BufMut implementation.

src/bytes.rs Show resolved Hide resolved
@jeromefroe jeromefroe merged commit 93988aa into jeromefroe:master Feb 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeromefroe jeromefroe jeromefroe left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Stargateur @jeromefroe