fix: Support maven extensions like Tycho adding system-scoped dependencies without a systemPath #5366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…information available to help resolving issues like #4969.
|
Any chance we can add project using Tycho to the maven/src/it tests? I'm fine if no - the changes look fine. |
Only if you know a way to trigger running it on Java 11 or 17 instead of Java 8 |
|
good enough - thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue #4969
Description of Change
When regular system-scoped dependencies don't yield a resolved system-scoped artifact attempt resolving the dependencies to make maven extension hook into the artifact resolution and provide us with the appropriate dependencies.
Have test cases been added to cover the new functionality?
No, adding an integrationtest with Tycho pomless 2.7.5. would require the build to run on JDK 11 or later, the updated Tycho 3 version would require JDK17 or later.
Manually verified that the scan runs to completion with the reproduction sample referred to in issue #4969 (both original Tycho 2.7.5 and the updated Tycho 3.0.0 versions)