Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add missing setting configuration for cli #5351

Merged
merged 1 commit into from
Jan 20, 2023
Merged

fix: add missing setting configuration for cli #5351

merged 1 commit into from
Jan 20, 2023

Conversation

jeremylong
Copy link
Owner

The configuration option exists - it was just never used when configuring the settings.

@boring-cyborg boring-cyborg bot added the cli changes to the cli label Jan 19, 2023
aikebah
aikebah approved these changes Jan 20, 2023
View reviewed changes
Copy link
Collaborator

@aikebah aikebah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was about to request documentation... but even the documentation is there

@aikebah aikebah added this to the 8.0.2 milestone Jan 20, 2023
@aikebah aikebah merged commit 790d1c3 into main Jan 20, 2023
@jeremylong jeremylong deleted the missingArgs branch February 1, 2023 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aikebah aikebah aikebah approved these changes

Assignees
No one assigned
Labels
cli changes to the cli
Projects
None yet
Milestone
8.0.2
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jeremylong @aikebah