Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: maven compatability #5152

Merged
merged 1 commit into from Dec 23, 2022
Merged

fix: maven compatability #5152

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions README.md
View file
Open in desktop
Expand Up @@ -252,13 +252,13 @@ mvn -s settings.xml install
Running dependency-check on dependency-check
--------------------------------------------

Dependency-check references several vulnerables dependencies that are never used
Dependency-check references several vulnerable dependencies that are never used
except as test resources. All of these optional test dependencies are included in
the `test-dependencies` profile. To run dependency-check against itself simple
exclude the `test-dependencies` profile;
exclude the `test-dependencies` profile:

```shell
mvn org.owasp:dependency-check-maven:aggregate -P-test-dependencies
mvn org.owasp:dependency-check-maven:aggregate -P-test-dependencies -DskipProvidedScope=true
```

Building the documentation
Expand Down
3 changes: 0 additions & 3 deletions maven/pom.xml
View file
Open in desktop
Expand Up @@ -175,9 +175,6 @@ Copyright (c) 2013 Jeremy Long. All Rights Reserved.
<name>releaseTesting</name>
</property>
</activation>
<properties>
<maven.api.version>3.1.0</maven.api.version>
</properties>
<build>
<plugins>
<plugin>
Expand Down
19 changes: 1 addition & 18 deletions pom.xml
View file
Open in desktop
Expand Up @@ -124,8 +124,7 @@ Copyright (c) 2012 - Jeremy Long
<slf4j.version>1.7.36</slf4j.version>
<logback.version>1.2.11</logback.version>

<!-- moved maven.api.version to the profile section -->
<!--maven.api.version>3.8.1</maven.api.version-->
<maven.api.version>3.1.0</maven.api.version>
<reporting.checkstyle-plugin.version>3.2.0</reporting.checkstyle-plugin.version>
<reporting.checkstyle.tool.version>9.3</reporting.checkstyle.tool.version>
<doxia-module-markdown.version>1.11.1</doxia-module-markdown.version>
Expand Down Expand Up @@ -1380,22 +1379,6 @@ Copyright (c) 2012 - Jeremy Long
</dependency>
</dependencies>
<profiles>
<profile>
<id>standard</id>
<!--
`releaseTesting` is used in the maven/pom.xml and downgrades the
Maven API to 3.1.0 during full refression testing to ensure that
no new Maven APIs were used and we maintain compatability with 3.1.
-->
<activation>
<property>
<name>!releaseTesting</name>
</property>
</activation>
<properties>
<maven.api.version>3.8.6</maven.api.version>
</properties>
</profile>
<profile>
<id>release</id>
<activation>
Expand Down