Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added local node_module check for NodePackageAnalyzer #4753

Merged
merged 3 commits into from Aug 19, 2022
Merged

Added local node_module check for NodePackageAnalyzer #4753

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6d324a6
Added local node_module check for NodePackageAnalyzer
Aug 15, 2022
61d7495
Changed check to support all variations of local paths
Aug 16, 2022
a00db29
Update core/src/main/java/org/owasp/dependencycheck/analyzer/NodePack…
jeremylong Aug 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions core/src/main/java/org/owasp/dependencycheck/analyzer/NodePackageAnalyzer.java
View file
Open in desktop
Expand Up @@ -297,10 +297,10 @@ public static boolean shouldSkipDependency(String name, String version, boolean

// this seems to produce crash sometimes, I need to tests
// using a local node_module is not supported by npm audit, it crash
if (Objects.nonNull(version) && version.startsWith("file:")) {
if (Objects.nonNull(version) && (version.startsWith("file:") || version.matches("^[.~]*/.*"))) {
jeremylong marked this conversation as resolved.
Show resolved Hide resolved
LOGGER.warn("dependency skipped: package.json contain an local node_module for {} seems to be "
+ "located {} npm audit doesn't support locally referenced modules",
name, version.replace("file:", ""));
name, version);
return true;
}
return false;
Expand Down