Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: maven compatability #5152

Merged
merged 1 commit into from Dec 23, 2022
Merged

fix: maven compatability #5152

merged 1 commit into from Dec 23, 2022

Conversation

jeremylong
Copy link
Owner

Resolves #5151

Reverts upgrade to maven dependencies.

@boring-cyborg boring-cyborg bot added the maven changes to the maven plugin label Dec 15, 2022
@jeremylong jeremylong added this to the 7.4.2 milestone Dec 15, 2022
@aikebah
Copy link
Collaborator

aikebah commented Dec 16, 2022

I wonder whether it would also be sufficient to mark the other maven library dependencies <scope>provided</scope>, but I think taking this conservative approach is a better safeguard anyhow to avoid incompatibilities.

@aikebah aikebah merged commit 84ff956 into main Dec 23, 2022
@jeremylong jeremylong deleted the mavenCompatability branch December 24, 2022 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aikebah aikebah aikebah approved these changes

Assignees
No one assigned
Labels
maven changes to the maven plugin
Projects
None yet
Milestone
7.4.2
Development

Successfully merging this pull request may close these issues.

Incompatibility with maven 3.3.9
2 participants
@jeremylong @aikebah