add option to verify <dependencyManagement/> section in POM #1552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
i've done some manual testing with both 'check' and 'aggregate' on project and all seems to work for good measure it should probably need an actual test-case |
jeremylong
approved these changes
Jan 1, 2019
|
Truly appreciate the PR .- thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue #1551
Description of Change
This PR adds the option to also scan the dependencyManagement section of POM's for vulnerablilities
Have test cases been added to cover the new functionality?
Yes
Note
consider this a rough draft or proof-of-concept, i'm not very familiar with the codebase, just putting this out there for review and commenting