Bump minimal required Elixir version to 1.12.0 #516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since PR jeremyjh#514, the [`Kernel.then/2` macro](https://hexdocs.pm/elixir/Kernel.html#then/2) is used, which was introduced in Elixir 1.12.0. If installed on older Elixir versions, it will fail to compile with the error below. ``` ==> dialyxir Compiling 66 files (.ex) == Compilation error in file lib/dialyxir/project.ex == ** (CompileError) lib/dialyxir/project.ex:365: undefined function then/2 (elixir) expanding macro: Kernel.|>/2 lib/dialyxir/project.ex:365: Dialyxir.Project (module) (elixir) expanding macro: Kernel.if/2 lib/dialyxir/project.ex:365: Dialyxir.Project (module) ``` Bump the minimal required Elixir version to communicate older versions are no longer supported. Elixir 1.12 is also the oldest version tested in the CI.
tombruijn
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since PR #514, the
Kernel.then/2macro is used, which was introduced in Elixir 1.12.0. If installed on older Elixir versions, it will fail to compile with the error below.Bump the minimal required Elixir version to communicate older versions are no longer supported. Elixir 1.12 is also the oldest version tested in the CI.
If it wasn't the intention to drop support for older Elixir versions, please close this PR :)