Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gitlab_ci cache files key example #505

Merged
merged 1 commit into from
Jun 13, 2023

Conversation

wkirschbaum
Copy link
Contributor

The current example is invalid:
jobs:build-dev:cache config contains unknown keys: files

The current example is invalid:
jobs:build-dev:cache config contains unknown keys: files
@wkirschbaum
Copy link
Contributor Author

I also just want to note that by default plt's will sit in the _build/dev folder, not the priv folder. Does it make sense to perhaps change this?

@jeremyjh
Copy link
Owner

I also just want to note that by default plt's will sit in the _build/dev folder, not the priv folder. Does it make sense to perhaps change this?

Well these are essentially build artifacts, and we don't want them checked into git so it makes sense to me to put them in the _build folder which is .gitignored by default, in .priv you'd have to .gitignore them particularly.

@jeremyjh jeremyjh merged commit 25717e5 into jeremyjh:master Jun 13, 2023
2 checks passed
@jeremyjh
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants