Add specs for underscore in host (rack#2072)

jeremyevans · Apr 25, 2023 · ab360dd · ab360dd
1 parent ccd445d
commit ab360dd
Showing 1 changed file with 9 additions and 0 deletions.
diff --git a/test/spec_request.rb b/test/spec_request.rb
@@ -186,6 +186,11 @@ class RackRequestTest < Minitest::Spec
     req.host.must_be_nil
     req.hostname.must_be_nil
 
+    req = make_request \
+      Rack::MockRequest.env_for("/", "HTTP_HOST" => "some_service:3001")
+    req.host.must_equal "some_service"
+    req.hostname.must_equal "some_service"
+
     req = make_request \
       Rack::MockRequest.env_for("/", "SERVER_NAME" => "example.org", "SERVER_PORT" => "9292")
     req.host.must_equal "example.org"
@@ -303,6 +308,10 @@ class RackRequestTest < Minitest::Spec
       Rack::MockRequest.env_for("/", "HTTP_HOST" => "www2.example.org:81")
     req.port.must_equal 81
 
+    req = make_request \
+      Rack::MockRequest.env_for("/", "HTTP_HOST" => "some_service:3001")
+    req.port.must_equal 3001
+
     req = make_request \
       Rack::MockRequest.env_for("/", "SERVER_NAME" => "example.org", "SERVER_PORT" => "9292")
     req.port.must_equal 9292