Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamically load requirements.txt in pyproject.toml #15

Merged
merged 4 commits into from Oct 7, 2023
Merged

Dynamically load requirements.txt in pyproject.toml #15

merged 4 commits into from Oct 7, 2023

Conversation

jepler
Copy link
Owner

@jepler jepler commented Oct 2, 2023

This allows use of pip install -r requirements.txt by users who prefer that way of trying out the package, while not affecting my typical usage.

This does create a dependency on a beta feature of setuptools, so it could be fragile.

Closes: #5

This allows use of `pip install -r requirements.txt` by users who prefer
that way of trying out the package, while not affecting my typical usage.

This does create a dependency on a beta feature of setuptools, so it
could be fragile.

Closes: #5
@jepler
Copy link
Owner Author

jepler commented Oct 2, 2023

@peterkaminski does this meet your needs? do you know anything more about why setuptools says this feature is "beta"?

@peterkaminski
Copy link
Contributor

@jepler yes, this is great. Thank you!

I don't have specific knowledge about why the feature is beta, but after some reading, it seems to be that it's "beta" because the maintainers wanted to see if they would get feedback about the naming of the directive, how it operated, etc.

There was also some consternation about the feature itself (if I'm reading correctly), but it also looks like they've decided to proceed with the feature anyway.

Here are the links I read:

@jepler
Copy link
Owner Author

jepler commented Oct 7, 2023

I also added an (arguably terrible) top level chap.py script, to allow running python -mchap or ./chap.py in the top level directory, after installing requirements with pip install -r requirements.txt.

@jepler jepler merged commit 36a4ebf into main Oct 7, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dynamically load requirements.txt in pyproject.toml
2 participants