Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a dedicated thread pool rather than Timer.get for DurableTaskStep.Execution.check #53

Merged
merged 5 commits into from
Oct 13, 2017
Merged

Use a dedicated thread pool rather than Timer.get for DurableTaskStep.Execution.check #53

merged 5 commits into from
Oct 13, 2017

Commits on Sep 27, 2017

  1. Use a dedicated thread pool rather than Timer.get for DurableTaskStep… 

    ….Execution.check, since it has often been observed to block for a while.
    @jglick
    jglick committed Sep 27, 2017
    Configuration menu
    Copy the full SHA
    c9c1364 View commit details
    Browse the repository at this point in the history

  2. Also apply WithThreadName. 

    Otherwise we get thread dumps showing many blocked calls to DurableTaskStep$Execution.check
with no indication of which agent is failing to respond.
    @jglick
    jglick committed Sep 27, 2017
    Configuration menu
    Copy the full SHA
    6f27534 View commit details
    Browse the repository at this point in the history

  3. Need to update baseline to be able to use workflow-support, which has… 

    … a newer baseline.
    @jglick
    jglick committed Sep 27, 2017
    Configuration menu
    Copy the full SHA
    f4ed021 View commit details
    Browse the repository at this point in the history

  4. Adjusting baselines tested against.

    @jglick
    jglick committed Sep 27, 2017
    Configuration menu
    Copy the full SHA
    60a11b1 View commit details
    Browse the repository at this point in the history

  5. Frequent flakes from queueAPIRestartable are likely due to a race con… 

    …dition: aborting an execution is not guaranteed to cancel node {} queue items synchronously.
    @jglick
    jglick committed Sep 27, 2017
    Configuration menu
    Copy the full SHA
    6ef007e View commit details
    Browse the repository at this point in the history