Use a dedicated thread pool rather than Timer.get for DurableTaskStep.Execution.check #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….Execution.check, since it has often been observed to block for a while.
|
This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation. |
Otherwise we get thread dumps showing many blocked calls to DurableTaskStep$Execution.check with no indication of which agent is failing to respond.
… a newer baseline.
|
Very flaky tests. Looking into it. |
…dition: aborting an execution is not guaranteed to cancel node {} queue items synchronously.
abayer
approved these changes
Sep 28, 2017
|
@reviewbybees done |
This was referenced Oct 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Analogous to #44. Downstream of jenkinsci/workflow-support-plugin#46.
@reviewbybees