Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-63958] - Update Jetty from 9.4.32.v20200930 to 9.4.33.v20201020 #124

Merged
merged 4 commits into from Oct 26, 2020

Conversation

oleg-nenashev
Copy link
Member

Picks up https://github.com/eclipse/jetty.project/releases/tag/jetty-9.4.33.v20201019 which includes a fix for jetty/jetty.project#5417 fix is out (PR: jetty/jetty.project#5419 ).

This is a foundation for a better fix than jenkinsci/jenkins#5017

CC @jenkinsci/core

Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed the changelog for 9.4.33 and did not see anything that caused me concerns.

@oleg-nenashev
Copy link
Member Author

[ERROR] Failed to execute goal on project winstone: Could not resolve dependencies for project org.jenkins-ci:winstone:jar:5.12-SNAPSHOT: The following artifacts could not be resolved: org.eclipse.jetty:jetty-server:jar:9.4.33.v20201019, org.eclipse.jetty:jetty-util:jar:9.4.33.v20201019, org.eclipse.jetty:jetty-servlet:jar:9.4.33.v20201019, org.eclipse.jetty:jetty-webapp:jar:9.4.33.v20201019, org.eclipse.jetty.http2:http2-server:jar:9.4.33.v20201019, org.eclipse.jetty.http2:http2-hpack:jar:9.4.33.v20201019, org.eclipse.jetty:jetty-alpn-server:jar:9.4.33.v20201019, org.eclipse.jetty:jetty-jmx:jar:9.4.33.v20201019, org.eclipse.jetty.websocket:websocket-server:jar:9.4.33.v20201019: Could not find artifact org.eclipse.jetty:jetty-server:jar:9.4.33.v20201019 in repo.jenkins-ci.org (https://repo.jenkins-ci.org/public/)

Jetty has not been fully propagated yet. I will try again in a few hours

Copy link
Member

@jglick jglick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What could possibly go wrong?

@olamy
Copy link
Member

olamy commented Oct 19, 2020

this Jetty release is only on staging status not yet approved.
Final version may change (or not)

@timja
Copy link
Member

timja commented Oct 19, 2020

this Jetty release is only on staging status not yet approved.
Final version may change (or not)

so won't be out by tomorrow?

@jglick
Copy link
Member

jglick commented Oct 20, 2020

Needs merge for conflict with #125.

@olamy
Copy link
Member

olamy commented Oct 22, 2020

release 9.4.33.v20201020 is now in maven central

@olamy olamy changed the title [JENKINS-63958] - Update Jetty from 9.4.32.v20200930 to 9.4.33.v20201019 [JENKINS-63958] - Update Jetty from 9.4.32.v20200930 to 9.4.33.v20201020 Oct 23, 2020
Signed-off-by: olivier lamy <olamy@apache.org>
@olamy olamy added dependencies java Pull requests that update Java code and removed java Pull requests that update Java code labels Oct 26, 2020
@olamy olamy merged commit a7e3258 into master Oct 26, 2020
@olamy olamy deleted the jetty-33 branch October 26, 2020 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants