Use BOM, and adapt to a change in GitSCM behavior

[jglick]

Noticed in jenkinsci/bom#431 that jenkinsci/git-plugin#1043 broke a longstanding test here (which ultimately should probably be rewritten to use some mock describables). Switching to the BOM and just temporarily overriding the git plugin version. Supersedes #58, #73, #74, #76, and #77.

[timja]

spotbugs issues on new core / spotbugs FTR

[jglick]

Yeah I know, I will fix shortly.

[MarkEWaite]

Thanks!

I assume this was an unavoidable break unless I left the @DataBoundConstructor of the GitSCM class unmodified. The change for the @DataBoundConstructor makes the Pipeline syntax clearer and removes an ancient undocumented experimental git plugin code.

[jetersen]

@jglick instead of supersedes block.

Consider using the keywords in the description

Closes #58 
Closes #73
Closes #74
Closes #76
Closes #77

[jglick]

Consider using the keywords in the description

I know about that, but it is unnecessary for Dependabot since it will automatically close superseded PRs.

[jetersen]

Right 😅 Didn't check the PRs just saw the block and thought phew forgetting to close the PRs would create noise my bad for interjecting.

[jglick]

@car-roll could we get a release of this, to unblock bom updates?

[jglick]

Guess not. This is the kind of plugin that would be a good candidate for JEP-229…