Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ClassLoaderValue compatible with PowerMock #402

Merged
merged 1 commit into from Aug 25, 2022

Conversation

jglick
Copy link
Member

@jglick jglick commented Aug 25, 2022

Amending #370. jenkinsci/email-ext-plugin#311 etc. were filed because it turned out there were problems running plugin-compat-tester against plugins still using PowerMock (discouraged: jenkinsci/plugin-pom#442):

java.lang.ExceptionInInitializerError
	at java.base/java.lang.Class.forName0(Native Method)
	at java.base/java.lang.Class.forName(Class.java:315)
	at javassist.runtime.Desc.getClassObject(Desc.java:72)
	at javassist.runtime.Desc.getClassType(Desc.java:181)
	at javassist.runtime.Desc.getType(Desc.java:151)
	at javassist.runtime.Desc.getType(Desc.java:107)
	at io.jenkins.blueocean.service.embedded.BaseTest.<init>(BaseTest.java:46)
	at io.jenkins.blueocean.service.embedded.ContainerFilterTest.<init>(ContainerFilterTest.java:34)
	at …
Caused by: java.lang.IllegalArgumentException: org.kohsuke.stapler.ClassLoaderValue$X referenced from a method is not visible from class loader
	at java.base/java.lang.reflect.Proxy$ProxyBuilder.ensureVisible(Proxy.java:858)
	at java.base/java.lang.reflect.Proxy$ProxyBuilder.validateProxyInterfaces(Proxy.java:681)
	at java.base/java.lang.reflect.Proxy$ProxyBuilder.<init>(Proxy.java:627)
	at java.base/java.lang.reflect.Proxy$ProxyBuilder.<init>(Proxy.java:635)
	at java.base/java.lang.reflect.Proxy.lambda$getProxyConstructor$0(Proxy.java:415)
	at java.base/jdk.internal.loader.AbstractClassLoaderValue$Memoizer.get(AbstractClassLoaderValue.java:329)
	at java.base/jdk.internal.loader.AbstractClassLoaderValue.computeIfAbsent(AbstractClassLoaderValue.java:205)
	at java.base/java.lang.reflect.Proxy.getProxyConstructor(Proxy.java:413)
	at java.base/java.lang.reflect.Proxy.getProxyClass(Proxy.java:384)
	at org.kohsuke.stapler.ClassLoaderValue.get(ClassLoaderValue.java:55)
	at org.kohsuke.stapler.MetaClassLoader.get(MetaClassLoader.java:53)
	at org.kohsuke.stapler.MetaClassLoader.<init>(MetaClassLoader.java:46)
	at org.jvnet.hudson.test.JenkinsRule.<clinit>(JenkinsRule.java:2792)
	... 31 more

Debugging shows that cl was e.g. AppClassLoader whereas X.class was from org.powermock.core.classloader.javassist.JavassistMockClassLoader. Use the version loaded from cl.

@jglick jglick requested review from basil and olamy August 25, 2022 12:20
@jglick jglick added the bug label Aug 25, 2022
@jglick
Copy link
Member Author

jglick commented Aug 25, 2022

BTW there is a ClassLoaderValue in Java 9+ which looks like it would work, but it is private.

@basil basil merged commit 981fdd9 into jenkinsci:master Aug 25, 2022
@jglick jglick deleted the ClassLoaderValue branch August 25, 2022 17:53
basil pushed a commit that referenced this pull request Aug 25, 2022
basil pushed a commit that referenced this pull request Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants