Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to use jcasc test harness #49

Merged
merged 1 commit into from
Jan 14, 2020

Conversation

timja
Copy link
Member

@timja timja commented Jan 14, 2020

JCasc had to create a new dependency that wasn't a tests classifier because maven doesn't allow you to bring dependencies through classifiers.

Upgrading here so that PCT works again,

Tracking:
jenkinsci/bom#164

Note: We'll need a release for PCT please

@jvz jvz merged commit c54340d into jenkinsci:master Jan 14, 2020
@jvz
Copy link
Member

jvz commented Jan 14, 2020

Tagged 1.18.1. Thanks for the PR!

@timja
Copy link
Member Author

timja commented Jan 18, 2020

Tagged 1.18.1. Thanks for the PR!

@jvz what do you think of backporting this to 1.17.x?

On the bom we're currently getting (jenkinsci/bom#172):

Require upper bound dependencies error for org.jenkins-ci:trilead-ssh2:build-217-jenkins-14 paths to dependency are:
+-io.jenkins.tools.bom:sample:6-SNAPSHOT
  +-org.jenkins-ci.main:jenkins-core:2.176.3
    +-org.jenkins-ci:trilead-ssh2:build-217-jenkins-14
and
+-io.jenkins.tools.bom:sample:6-SNAPSHOT
  +-org.jenkins-ci.main:jenkins-core:2.176.3
    +-org.jenkins-ci.main:cli:2.176.3
      +-org.jenkins-ci:trilead-ssh2:build214-jenkins-1
and
+-io.jenkins.tools.bom:sample:6-SNAPSHOT
  +-org.jenkins-ci.main:jenkins-core:2.176.3
    +-org.kohsuke:trilead-putty-extension:1.2
      +-org.jenkins-ci:trilead-ssh2:build214-jenkins-1
and
+-io.jenkins.tools.bom:sample:6-SNAPSHOT
  +-org.jenkins-ci.plugins:ssh-slaves:1.30.2
    +-org.jenkins-ci.plugins:ssh-credentials:1.18.1
      +-org.jenkins-ci.plugins:trilead-api:1.0.5
        +-org.jenkins-ci:trilead-ssh2:build-217-jenkins-16

I think it's either backport, or fix the bom PR for 2.190.x and then only having new jcasc versions in the bom on >= 2.190.x which isn't ideal.

cc @jglick if you have any other ideas.

@jvz
Copy link
Member

jvz commented Jan 20, 2020

If you'd like to backport, please file a PR and I can release from a branch.

@timja
Copy link
Member Author

timja commented Jan 20, 2020

If you'd like to backport, please file a PR and I can release from a branch.

can you create the origin branch that I can PR to please?

@timja
Copy link
Member Author

timja commented Jan 20, 2020

One liner:

git checkout ssh-credentials-1.17.3 && git checkout -b 1.17.x && git push -u origin 1.17.x

@jvz
Copy link
Member

jvz commented Jan 20, 2020

Branch created!

@timja
Copy link
Member Author

timja commented Jan 20, 2020

Backport PR: #50

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants