Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Whitelist jenkins.model.Jenkins.VERSION #548

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jtnord
Copy link
Member

@jtnord jtnord commented Dec 18, 2023

useful when you need the Jenkins version in a pipeline (e.g. to obtain a corresponing agent image for k8s plugin)

Testing done

Submitter checklist

Edit tasklist title
Beta Give feedback Tasklist Submitter checklist, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
    Options
  2. Ensure that the pull request title represents the desired changelog entry
    Options
  3. Please describe what you did
    Options
  4. Link to relevant issues in GitHub or Jira
    Options
  5. Link to relevant pull requests, esp. upstream and downstream changes
    Options
  6. Ensure you have provided tests - that demonstrates feature works or fixes the issue
    Options

useful when you need the Jenkins version in a pipeline (e.g. to obtain a corresponing agent image for k8s plugin)
@jtnord jtnord changed the title whitelist jenkins.model.Jenkin.VERSION whitelist jenkins.model.Jenkins.VERSION Dec 18, 2023
Copy link
Member

@jglick jglick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Harmless to whitelist. Something like jenkinsci/workflow-basic-steps-plugin#71 would be better if it existed I think.

@jglick jglick changed the title whitelist jenkins.model.Jenkins.VERSION Whitelist jenkins.model.Jenkins.VERSION Dec 18, 2023
@jtnord jtnord marked this pull request as ready for review December 19, 2023 10:31
@jtnord jtnord requested a review from a team as a code owner December 19, 2023 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants