[JENKINS-62448] Enhance information displayed in approval page #300

Wadeck · 2020-05-25T16:22:20Z

With this PR, we are storing more information than before. The change is incremental, it means that if you have some hashes already approved, they will just not have any metadata until used. When used, the metadata will be saved.

It means, after some weeks / months, you will know easily which entries are approved but not used (or no longer used).

If you have troubles with this PR, you can disable this feature by setting the System Property: org.jenkinsci.plugins.scriptsecurity.scripts.ScriptApproval.metadataGathering to false.

There is no test addition at the moment, I want to have feedbacks on the approach before investing time on the testing part.

Testing notes

Having pipeline installed will ease the testing.
Also, if you have an instance with already some approved items, it could be useful. I did some manual testing of "migration" without any issues but not 100% sure to have covered all corner cases.

To generate a full script approval request

You can create a new pipeline with a user without RUN_SCRIPT permission (just Job/Configure). Configure the pipeline content locally ("Pipeline script"), and do not check the "Use Groovy Sandbox". A simple echo 'hello from pipeline' is sufficient.
Then run the pipeline.

To generate a signature approval request

Same as full script but you check the Groovy Sandbox.
new File(".") will trigger the signature for new java.io.File java.lang.String.

To generate a class entry approval request

It's a bit more complicated (or at least I was not able to find a better way). You can install EnvInject plugin. Then inside a Freestyle project, you configure the "Build Environment", with "Inject environment variables to the build process". As Groovy Script, put anything and use "Additional classpath", you can use the regular Artifactory of Jenkins to provide links.
I was using: https://repo.jenkins-ci.org/javanet2-cache/org/jvnet/hudson/main/maven-plugin/1.301/maven-plugin-1.301.hpi.

(🔥 Updated screenshots in #300 🔥)

Screenshots

Full script pending approvals

Full script pending approvals (with annotations)

Full script already approved

Full script already approved (with annotations)

Other tabs kept the same

Scope

The objective of the PR is only to provide metadata and new features for the Full Script approval process as it's the most annoying part. The two other categories are let aside (at least for the moment). Their script parts is let unmodified, just split and moved.

Reviewers

@jsoref as you worked on #282
@josephbrueggen for the UI/UX
@fqueiruga for the JavaScript review
@dwnusbaum as maintainer of the plugin
@jeffret-b as you worked on this effort too

timja

Nice work!

One question on the hash column and whether it needs to be exposed to the user,
Haven't really looked at the code itself just the description and screenshot

...s/org/jenkinsci/plugins/scriptsecurity/scripts/ScriptApproval/tabs/fullScript_approved.jelly

...ces/org/jenkinsci/plugins/scriptsecurity/scripts/ScriptApproval/tabs/classPath_pending.jelly

.../jenkinsci/plugins/scriptsecurity/scripts/ScriptApproval/tabs/fullScript_approved.properties

src/main/java/org/jenkinsci/plugins/scriptsecurity/scripts/ScriptApproval.java

src/main/java/org/jenkinsci/plugins/scriptsecurity/scripts/metadata/MetadataStorage.java

src/main/resources/org/jenkinsci/plugins/scriptsecurity/scripts/Messages.properties

...g/jenkinsci/plugins/scriptsecurity/scripts/ScriptApproval/tabs/fullScript_pending.properties

...es/org/jenkinsci/plugins/scriptsecurity/scripts/ScriptApproval/tabs/signature_approved.jelly

...ces/org/jenkinsci/plugins/scriptsecurity/scripts/ScriptApproval/tabs/signature_pending.jelly

jeffret-b · 2020-05-26T21:36:43Z

There are some weird, interesting situations with this if multiple jobs have the same script. Some of them probably exist even before this PR but some are exacerbated by the addition of tracking info after the script has been approved.

Here's one example scenario:

Create a job a with a script that needs to be approved. For example I just used the "Hello World" example script.
Create a second job b with the exact same script that needs to be approved.
Login as admin to approve scripts.
Only the first version shows as needing approval via the job a context.
Check job b. It no longer shows that the script needs approval.
Run job b.
Check the "Script - Approved" tab. It still shows the context as job a even though it has never run.

I'm not sure this is really a problem, though. First, it's rather a corner case for the exact same script to be used in multiple different jobs. I can imagine some situations in which that might be valid, but they're kind of odd and I'm not sure we need to worry about them. Second, even the behavior is odd, I don't know that it is wrong or harmful. The gain from improving the UI / UX here probably outweighs these oddities in these corner cases.

jeffret-b · 2020-05-26T21:41:34Z

A very minor detail at this point, but it looks odd to me to have the tab named "Script - approved" but then to have the content title be "Approved scripts". The first tab for "Script - pending approvals" is more similar to "Scripts pending approval" but still a little disconcerting, especially the shift from singular to plural.

oleg-nenashev · 2020-05-27T15:21:40Z

Thank you for this contribution! It is much appreciated.

Are you doing it as a part of the Jenkins UI/UX Hackfest? If so, please consider reporting this contribution here so that we could facilitate reviews and share the story 👍

...s/org/jenkinsci/plugins/scriptsecurity/scripts/ScriptApproval/tabs/fullScript_approved.jelly

…iptApproval.java Co-authored-by: Josh Soref <jsoref@users.noreply.github.com>

…adata/MetadataStorage.java Co-authored-by: Josh Soref <jsoref@users.noreply.github.com>

…s/Messages.properties Co-authored-by: Josh Soref <jsoref@users.noreply.github.com>

…s/ScriptApproval/tab-custom.jelly Co-authored-by: Josh Soref <jsoref@users.noreply.github.com>

…s/ScriptApproval/tabs/fullScript_pending.properties Co-authored-by: Josh Soref <jsoref@users.noreply.github.com>

…s/ScriptApproval/tabs/signature_approved.jelly Co-authored-by: Josh Soref <jsoref@users.noreply.github.com>

…s/ScriptApproval/tabs/fullScript_pending.properties Co-authored-by: Josh Soref <jsoref@users.noreply.github.com>

…s/ScriptApproval/tab-with-body.jelly Co-authored-by: Josh Soref <jsoref@users.noreply.github.com>

...ces/org/jenkinsci/plugins/scriptsecurity/scripts/ScriptApproval/tabs/signature_pending.jelly

Co-authored-by: Josh Soref <jsoref@users.noreply.github.com>

jglick · 2020-05-29T14:12:57Z

It looks nice. I am just concerned that by making the whole-script approval system look nice, we are implicitly encouraging people to use it, when really this was a terrible idea that I should never have introduced to begin with and it would better be deleted. 🤷‍♂️

Wadeck · 2020-05-29T14:38:48Z

it would better be deleted

If you have a good wording / warning / recommended approach, or similar, please share it/them, I can add them ;)

I was working on this topic because I got multiple feedbacks that the UX was not helpful and some users had 100s of approved scripts without knowing if they are using them or not.

Wadeck · 2020-05-29T14:57:34Z

Added some annotated screenshots and put more highlight on that section

jglick · 2020-05-29T18:58:58Z

recommended approach

Preferably use the sandbox. Where this is impractical, because your script is basically implementing plugin-like functionality, use a (trusted / global) Groovy library, in the case of Pipeline. For scripting in freestyle projects, if there is no other alternative, limit job configuration to Jenkins administrators (was RUN_SCRIPTS, now ADMINISTER but not MANAGE), who can freely save scripts without them appearing on this page.

.../jenkinsci/plugins/scriptsecurity/scripts/ScriptApproval/tabs/fullScript_approved.properties

...g/jenkinsci/plugins/scriptsecurity/scripts/ScriptApproval/tabs/fullScript_pending.properties

...enkinsci/plugins/scriptsecurity/scripts/ScriptApprovalTest/legacyApproval/scriptApproval.xml

Wadeck · 2020-08-24T07:54:44Z

From Daniel:

As 'user', create a Pipeline, write a script that hasn't been used before, disable sandbox, save.
As 'user', build the job, it fails
As 'admin', approve the script.
As 'user' build the job, it works
As 'admin', delete from approvals
As 'user', build the job, it fails

Expected: Script is now pending approval
Actual: It's neither approved nor pending

daniel-beck · 2020-08-24T08:12:32Z

Some UI feedback:

I don't think it's useful to show badges with the number of already approved entries. I associated badges with "unread messages", while these tabs don't have content that needs attention. Badges should be limited to content requiring action.
I wonder whether it makes sense to hide tabs for empty lists, so that the most common UI would only show "approved scripts" and "approved signatures", and classpath-related content to only show rarely. This could probably go either way.

daniel-beck · 2020-08-24T08:15:04Z

.../jenkinsci/plugins/scriptsecurity/scripts/ScriptApproval/tabs/fullScript_approved.properties

+noContextItemSinceMetadata=N/A
+noContextItemSinceMetadata_tooltip=The context item was not provided by the code asking for approval.
+
+emptyMetadata=There is no metadata for this approval


Suggested change

emptyMetadata=There is no metadata for this approval

emptyMetadata=This script has been approved before Script Security 1.75 and no additional metadata has been recorded yet. Once this script is executed, additional metadata will be added.

Suggested change

emptyMetadata=There is no metadata for this approval

emptyMetadata=This script was approved before Script Security 1.75 and no additional metadata has been recorded yet. Once this script is executed, additional metadata will be added.

Both proposals seem to pollute the space due to the size of the sentence.

Proof

After

Before (with the icon for tooltip discoverability)

Before (with just the cursor: help)

Going with no modification. This could be improved in a follow up PR.

daniel-beck · 2020-08-24T08:15:14Z

.../jenkinsci/plugins/scriptsecurity/scripts/ScriptApproval/tabs/fullScript_approved.properties

+noContextItemSinceMetadata_tooltip=The context item was not provided by the code asking for approval.
+
+emptyMetadata=There is no metadata for this approval
+emptyMetadata_tooltip=If the script is used after the metadata introduction, some metadata will be displayed here. \


This tooltip lacks discoverability.

I tried with a help icon but it will require to have newer version of core to have the latest help icon, so keeping it simple for the moment with cursor: help

Cursor

.../jenkinsci/plugins/scriptsecurity/scripts/ScriptApproval/tabs/fullScript_approved.properties

daniel-beck · 2020-08-24T08:20:04Z

.../jenkinsci/plugins/scriptsecurity/scripts/ScriptApproval/tabs/fullScript_approved.properties

+notApprovedSinceMetadata=N/A
+notApprovedSinceMetadata_tooltip=It was not approved since the introduction of metadata.
+noKnownApproverSinceMetadata=N/A
+noKnownApproverSinceMetadata_tooltip=It was not approved since the introduction of metadata.


When are these shown?

Fwiw while I suggest changing a has been elsewhere to was, these should be has not been.

When a script is approved before the metadata introduction, and then is used. We do not have the information on who approved it.

.../jenkinsci/plugins/scriptsecurity/scripts/ScriptApproval/tabs/fullScript_approved.properties

daniel-beck · 2020-08-24T08:23:13Z

Haven't looked in-depth at the code yet, but this looks a lot like a change that necessitates a compatibility warning because downgrades will be difficult. Thoughts?

Wadeck · 2020-08-24T08:26:21Z

I don't think it's useful to show badges with the number of already approved entries. I associated badges with "unread messages", while these tabs don't have content that needs attention. Badges should be limited to content requiring action.

Great idea, I will change this.

I wonder whether it makes sense to hide tabs for empty lists, so that the most common UI would only show "approved scripts" and "approved signatures", and classpath-related content to only show rarely. This could probably go either way.

I am not fan of UI elements being hidden until required. This reduce the likelihood the users will know where to go when they need this. If they are "used" to have them shown, it's easier.

Haven't looked in-depth at the code yet, but this looks a lot like a change that necessitates a compatibility warning because downgrades will be difficult. Thoughts?

I am just adding metadata. If you go back, the metadata will not be used any longer. The original XML file is not touched.

daniel-beck · 2020-08-24T18:37:36Z

Looking at something like

I wonder whether it would make sense to use a checksum prefix to identify the specific entry, both when there is, and when there is not, additional metadata. The checksum is all we have in some cases, but we always have that.

(I'm not proposing to remove the pre-approval checkmark, but Preview.app just isn't a good drawing program!)

jglick · 2020-08-24T18:52:47Z

Maybe we can merge something that is good enough? This entire PR touches on functionality which you should never be using to begin with, so unless the behavior is clearly wrong, it does not make sense to sink a lot of time into it IMO.

src/main/java/org/jenkinsci/plugins/scriptsecurity/scripts/ScriptApproval.java

- Wording / tooltips - Removal of badges when there is no needed action - Stop using deprecated ACL.impersonate - Stop using SecurityContextHolder when Jenkins is sufficient - Remove all occurrences of acegi usage in the plugin

Wadeck · 2020-09-02T09:31:03Z

I wonder whether it makes sense to hide tabs for empty lists, so that the most common UI would only show "approved scripts" and "approved signatures", and classpath-related content to only show rarely. This could probably go either way.

New version

From Daniel:
As 'user', [...]
Expected: Script is now pending approval
Actual: It's neither approved nor pending

It's a bug already present before this PR :(

script-security-plugin/src/main/java/org/jenkinsci/plugins/scriptsecurity/scripts/ScriptApproval.java

Line 637 in fcb41b7

    
           // Probably need not add to pendingScripts, since generally that would have happened already in configuring.

^- in the "using" method.

I will not modify this method as it could have some impacts I am not aware of (like having script being auto-approved or related stuff)

daniel-beck · 2020-09-02T09:44:00Z

I will not modify this method as it could have some impacts I am not aware of (like having script being auto-approved or related stuff)

AFAIUI this PR newly adds the capability to un-approve specific single scripts, so what wasn't a (big) problem before is now probably much more relevant.

Wadeck · 2020-09-02T09:48:45Z

@dwnusbaum @jglick any thoughts on the recent comments? (the bug about approval => revocation => not possible to put back in pending)

Modifying the using method could have terrible side effects depending on the plugin calling it. I am not confident enough to propose such bug correction in this PR.

jeffret-b · 2020-09-11T21:24:50Z

I am not fan of UI elements being hidden until required. This reduce the likelihood the users will know where to go when they need this. If they are "used" to have them shown, it's easier.

I strongly agree with this.

AFAIUI this PR newly adds the capability to un-approve specific single scripts, so what wasn't a (big) problem before is now probably much more relevant.

This seems like a legitimate concern. Providing a new capability that introduces problems because of existing limitations, creates a valid concern. I'm just not sure how big of a concern it is. Does it override Jesse's earlier desire to "merge something that is good enough"? My tentative answer is that we can merge something that is good enough when it comes to some of the UI and layout, but the introduction of a new, potentially confusing or limiting capability needs correction.

Wadeck · 2020-09-14T06:06:11Z

Due to the bug discovered by Daniel, this PR is currently blocked by JENKINS-63668.

☁️ 🐝 internal tickets: JENSEC-863 -> JENSEC-1243

jsoref · 2020-09-14T14:05:52Z

.../jenkinsci/plugins/scriptsecurity/scripts/ScriptApproval/tabs/fullScript_approved.properties

+noScriptCodeSinceMetadata_tooltip=The approval was given while the metadata was not gathered.
+approvedContextUser=Requester
+approvedContextItem=Context
+wasPreapproved_tooltip=The script content was approved directly during configuration, meaning it comes from a user with the permission to run scripts.


Suggested change

wasPreapproved_tooltip=The script content was approved directly during configuration, meaning it comes from a user with the permission to run scripts.

wasPreapproved_tooltip=The script content written by a user with permission to run scripts (implicit approval).

jsoref · 2020-09-14T14:09:52Z

.../jenkinsci/plugins/scriptsecurity/scripts/ScriptApproval/tabs/fullScript_approved.properties

+noUsageCountSinceMetadata_tooltip=It was not used since the introduction of metadata.
+notUsedSinceMetadata=N/A
+notUsedSinceMetadata_tooltip=It was not used since the introduction of metadata.
+notApprovedSinceMetadata=N/A
+notApprovedSinceMetadata_tooltip=It was not approved since the introduction of metadata.
+noKnownApproverSinceMetadata=N/A
+noKnownApproverSinceMetadata_tooltip=It was not approved since the introduction of metadata.


Suggested change

noUsageCountSinceMetadata_tooltip=It was not used since the introduction of metadata.

notUsedSinceMetadata=N/A

notUsedSinceMetadata_tooltip=It was not used since the introduction of metadata.

notApprovedSinceMetadata=N/A

notApprovedSinceMetadata_tooltip=It was not approved since the introduction of metadata.

noKnownApproverSinceMetadata=N/A

noKnownApproverSinceMetadata_tooltip=It was not approved since the introduction of metadata.

noUsageCountSinceMetadata_tooltip=It has not been used since the introduction of metadata.

notUsedSinceMetadata=N/A

notUsedSinceMetadata_tooltip=It has not been used since the introduction of metadata.

notApprovedSinceMetadata=N/A

notApprovedSinceMetadata_tooltip=It has not been approved since the introduction of metadata.

noKnownApproverSinceMetadata=N/A

noKnownApproverSinceMetadata_tooltip=It has not been approved since the introduction of metadata.

fqueiruga · 2020-11-27T11:33:49Z

How can we resurrect this?

Wadeck · 2020-11-27T12:43:39Z

@fqueiruga Either you convince the people (mainly Jeff, a bit Daniel) blocking this PR that the existing bug should not block this PR, or convince pipeline people the reported bug should be prioritized :)

[JENKINS-62448] Enhance information displayed in approval page

cbfedb6

Wadeck mentioned this pull request May 25, 2020

[JENKINS-60682] Improve scriptApproval ux #282

Open

dwnusbaum self-requested a review May 26, 2020 13:22

timja reviewed May 26, 2020

View reviewed changes

...s/org/jenkinsci/plugins/scriptsecurity/scripts/ScriptApproval/tabs/fullScript_approved.jelly Outdated Show resolved Hide resolved

fqueiruga reviewed May 26, 2020

View reviewed changes

...ces/org/jenkinsci/plugins/scriptsecurity/scripts/ScriptApproval/tabs/classPath_pending.jelly Show resolved Hide resolved

.../jenkinsci/plugins/scriptsecurity/scripts/ScriptApproval/tabs/fullScript_approved.properties Outdated Show resolved Hide resolved

jsoref reviewed May 26, 2020

View reviewed changes

...ces/org/jenkinsci/plugins/scriptsecurity/scripts/ScriptApproval/tabs/signature_pending.jelly Outdated Show resolved Hide resolved

Wadeck mentioned this pull request May 28, 2020

Script security enhancement jenkinsci/ui-ux-hackfest-2020#133

Closed

jglick reviewed May 28, 2020

View reviewed changes

...s/org/jenkinsci/plugins/scriptsecurity/scripts/ScriptApproval/tabs/fullScript_approved.jelly Outdated Show resolved Hide resolved

Wadeck and others added 11 commits May 29, 2020 15:15

Update src/main/java/org/jenkinsci/plugins/scriptsecurity/scripts/Scr…

b7a3312

…iptApproval.java Co-authored-by: Josh Soref <jsoref@users.noreply.github.com>

Update src/main/java/org/jenkinsci/plugins/scriptsecurity/scripts/Scr…

4c583a4

…iptApproval.java Co-authored-by: Josh Soref <jsoref@users.noreply.github.com>

Update src/main/java/org/jenkinsci/plugins/scriptsecurity/scripts/met…

349ac04

…adata/MetadataStorage.java Co-authored-by: Josh Soref <jsoref@users.noreply.github.com>

Update src/main/java/org/jenkinsci/plugins/scriptsecurity/scripts/met…

c559fe8

…adata/MetadataStorage.java Co-authored-by: Josh Soref <jsoref@users.noreply.github.com>

Update src/main/resources/org/jenkinsci/plugins/scriptsecurity/script…

1d39eff

…s/Messages.properties Co-authored-by: Josh Soref <jsoref@users.noreply.github.com>

Update src/main/resources/org/jenkinsci/plugins/scriptsecurity/script…

de369d6

…s/ScriptApproval/tab-custom.jelly Co-authored-by: Josh Soref <jsoref@users.noreply.github.com>

Update src/main/resources/org/jenkinsci/plugins/scriptsecurity/script…

e4708f7

…s/ScriptApproval/tabs/fullScript_pending.properties Co-authored-by: Josh Soref <jsoref@users.noreply.github.com>

Update src/main/resources/org/jenkinsci/plugins/scriptsecurity/script…

380deda

…s/ScriptApproval/tabs/signature_approved.jelly Co-authored-by: Josh Soref <jsoref@users.noreply.github.com>

Update src/main/resources/org/jenkinsci/plugins/scriptsecurity/script…

79b1995

…s/ScriptApproval/tabs/fullScript_pending.properties Co-authored-by: Josh Soref <jsoref@users.noreply.github.com>

Update src/main/resources/org/jenkinsci/plugins/scriptsecurity/script…

0ea0c93

…s/ScriptApproval/tabs/fullScript_pending.properties Co-authored-by: Josh Soref <jsoref@users.noreply.github.com>

Update src/main/resources/org/jenkinsci/plugins/scriptsecurity/script…

e978559

…s/ScriptApproval/tab-with-body.jelly Co-authored-by: Josh Soref <jsoref@users.noreply.github.com>

Wadeck commented May 29, 2020

View reviewed changes

...ces/org/jenkinsci/plugins/scriptsecurity/scripts/ScriptApproval/tabs/signature_pending.jelly Outdated Show resolved Hide resolved

Apply suggestions from code review

eadf75f

Co-authored-by: Josh Soref <jsoref@users.noreply.github.com>

oleg-nenashev mentioned this pull request Jun 1, 2020

Report unreported contributions jenkinsci/ui-ux-hackfest-2020#222

Closed

Wadeck requested a review from fqueiruga August 18, 2020 13:55

Wadeck added 2 commits August 19, 2020 15:58

Adding migration tests

0b0b624

Adjusting existing tests

fa17df8

jsoref reviewed Aug 19, 2020

View reviewed changes

Wadeck added 4 commits August 20, 2020 08:46

Adjusting existing tests

8f55c06

Adjust grammar

65926ce

Adjust another wording

9dc032c

Merge remote-tracking branch 'origin/UX_revamp' into UX_revamp

18bcb49

daniel-beck reviewed Aug 24, 2020

View reviewed changes

jglick mentioned this pull request Aug 28, 2020

Allow selected scripts to be removed from approvals #202

Closed

jglick reviewed Aug 28, 2020

View reviewed changes

src/main/java/org/jenkinsci/plugins/scriptsecurity/scripts/ScriptApproval.java Outdated Show resolved Hide resolved

src/main/java/org/jenkinsci/plugins/scriptsecurity/scripts/ScriptApproval.java Outdated Show resolved Hide resolved

Adjustment after review

fcb41b7

- Wording / tooltips - Removal of badges when there is no needed action - Stop using deprecated ACL.impersonate - Stop using SecurityContextHolder when Jenkins is sufficient - Remove all occurrences of acegi usage in the plugin

jsoref reviewed Sep 14, 2020

View reviewed changes

MarkRx mentioned this pull request Feb 15, 2021

[JENKINS-62708] Add JCasC support for approved script hashes #329

Merged

dwnusbaum mentioned this pull request Aug 31, 2022

[JENKINS-41516] Add script console listener jenkinsci/jenkins#6539

Closed

11 tasks

meiswjn mentioned this pull request Nov 27, 2023

[JENKINS-63668] fix: auto re-request approval once dismissed #546

Draft

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[JENKINS-62448] Enhance information displayed in approval page #300

[JENKINS-62448] Enhance information displayed in approval page #300

Wadeck commented May 25, 2020 •

edited

timja left a comment

jeffret-b commented May 26, 2020

jeffret-b commented May 26, 2020

oleg-nenashev commented May 27, 2020

jglick commented May 29, 2020

Wadeck commented May 29, 2020

Wadeck commented May 29, 2020

jglick commented May 29, 2020

Wadeck commented Aug 24, 2020 •

edited

daniel-beck commented Aug 24, 2020

daniel-beck Aug 24, 2020

jsoref Aug 24, 2020

Wadeck Sep 2, 2020

daniel-beck Aug 24, 2020

Wadeck Sep 2, 2020

daniel-beck Aug 24, 2020

jsoref Aug 24, 2020

Wadeck Sep 2, 2020

daniel-beck commented Aug 24, 2020

Wadeck commented Aug 24, 2020 •

edited

daniel-beck commented Aug 24, 2020

jglick commented Aug 24, 2020

Wadeck commented Sep 2, 2020

daniel-beck commented Sep 2, 2020

Wadeck commented Sep 2, 2020 •

edited

jeffret-b commented Sep 11, 2020

Wadeck commented Sep 14, 2020 •

edited

jsoref Sep 14, 2020

jsoref Sep 14, 2020

fqueiruga commented Nov 27, 2020

Wadeck commented Nov 27, 2020

	emptyMetadata=There is no metadata for this approval
	emptyMetadata=This script has been approved before Script Security 1.75 and no additional metadata has been recorded yet. Once this script is executed, additional metadata will be added.

	emptyMetadata=There is no metadata for this approval
	emptyMetadata=This script was approved before Script Security 1.75 and no additional metadata has been recorded yet. Once this script is executed, additional metadata will be added.

	wasPreapproved_tooltip=The script content was approved directly during configuration, meaning it comes from a user with the permission to run scripts.
	wasPreapproved_tooltip=The script content written by a user with permission to run scripts (implicit approval).

[JENKINS-62448] Enhance information displayed in approval page #300

Are you sure you want to change the base?

[JENKINS-62448] Enhance information displayed in approval page #300

Conversation

Wadeck commented May 25, 2020 • edited

Testing notes

To generate a full script approval request

To generate a signature approval request

To generate a class entry approval request

Full script pending approvals

Full script pending approvals (with annotations)

Full script already approved

Full script already approved (with annotations)

Other tabs kept the same

Scope

Reviewers

timja left a comment

Choose a reason for hiding this comment

jeffret-b commented May 26, 2020

jeffret-b commented May 26, 2020

oleg-nenashev commented May 27, 2020

jglick commented May 29, 2020

Wadeck commented May 29, 2020

Wadeck commented May 29, 2020

jglick commented May 29, 2020

Wadeck commented Aug 24, 2020 • edited

daniel-beck commented Aug 24, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

After

Before (with the icon for tooltip discoverability)

Before (with just the cursor: help)

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

daniel-beck commented Aug 24, 2020

Wadeck commented Aug 24, 2020 • edited

daniel-beck commented Aug 24, 2020

jglick commented Aug 24, 2020

Wadeck commented Sep 2, 2020

daniel-beck commented Sep 2, 2020

Wadeck commented Sep 2, 2020 • edited

jeffret-b commented Sep 11, 2020

Wadeck commented Sep 14, 2020 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fqueiruga commented Nov 27, 2020

Wadeck commented Nov 27, 2020

Wadeck commented May 25, 2020 •

edited

Wadeck commented Aug 24, 2020 •

edited

Wadeck commented Aug 24, 2020 •

edited

Wadeck commented Sep 2, 2020 •

edited

Wadeck commented Sep 14, 2020 •

edited