-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to use jcasc test harness #284
Conversation
@dwnusbaum chance we could get a review/merge only one left blocking jenkinsci/bom#172 😅 |
there's a few more 😉, the pipeline has failFast on the parallel block, each one we fix reveals more failures, but would be great to get a review / merge / release |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! The new artifact pulls in a ton of dependencies, most notably jackson-databind, but we should never use any of those dependencies in this plugin in compile scope so I don't anticipate any conflicts that might require transitive dependencies to be excluded or anything.
@dwnusbaum could you merge and release pretty please ❤️ |
or @bitwiseman :) |
@timja My plan is to release this in the next week or so. |
JCasc had to create a new dependency that wasn't a
tests
classifier because maven doesn't allow you to bring dependencies through classifiers.Upgrading here so that PCT works again,
Tracking:
jenkinsci/bom#164
Note: We'll need a release for PCT please