[JENKINS-63350] update pac4j to 3.9.0 #90

kuisathaverat · 2020-08-08T13:26:35Z

See JENKINS-63350.

Update pac4j to 3.9.0 depends on jenkinsci/jenkins#4848

Submitter checklist

JIRA issue is well described
Appropriate autotests or explanation to why this change has no tests

pom.xml

jglick · 2020-11-13T13:12:22Z

pom.xml

@@ -98,8 +101,13 @@ under the License.
    <dependency>
      <groupId>org.pac4j</groupId>
      <artifactId>pac4j-saml</artifactId>
-      <version>3.8.3</version>
+      <!-- versions 4.x.x require JDK 11 -->


Then set java.level to 11 I guess? Not sure of status of jenkinsci/plugin-pom#133.

I think is fine, 3.9.0 was released a few days ago

Jenkinsfile

jglick · 2020-11-13T13:14:10Z

pom.xml

      <exclusions>
+        <exclusion>
+          <groupId>org.springframework</groupId>
+          <artifactId>spring-beans</artifactId>


You may need to exclude more. Pay attention to what gets bundled in the *.hpi (also printed to build log).

yep, there is a bunch of transitive dependencies that can be removed

is there any way to acknowledge(remove the warnings) the dependencies? there are some warnings that come from the hpi plugin, but those dependencies are needed and I do not want to add all those dependencies manually to the plugin pom.

is there any way to acknowledge(remove the warnings)

Yes but do not do that.

there are some warnings that come from the hpi plugin, but those dependencies are needed

You can exclude dependencies you know you will not use, or you know you can use in the version supplied by core. Or you can switch to pluginFirstClassLoader and forget about accurate testing with JenkinsRule (must do it manually). Think twice, actually several times, before doing anything out of the ordinary. https://www.jenkins.io/doc/developer/plugin-development/dependencies-and-class-loading/

I have excluded all that are not needed or are already in the Jenkins Core. so I guess that either I add these libraries to the pom or I live with these warnings

[WARNING] Bundling transitive dependency jcommander-1.48.jar (via pac4j-saml) -- [WARNING] Bundling transitive dependency woodstox-core-5.0.3.jar (via pac4j-saml) [WARNING] Bundling transitive dependency istack-commons-runtime-3.0.8.jar (via pac4j-saml) [WARNING] Bundling transitive dependency FastInfoset-1.2.16.jar (via pac4j-saml) [WARNING] Bundling transitive dependency metrics-core-3.1.2.jar (via pac4j-saml) [WARNING] Bundling transitive dependency jakarta.xml.bind-api-2.3.2.jar (via pac4j-saml) [WARNING] Bundling transitive dependency javax.json-api-1.0.jar (via pac4j-saml) [WARNING] Bundling transitive dependency joda-time-2.9.9.jar (via pac4j-saml) [WARNING] Bundling transitive dependency xmlsectool-2.0.0.jar (via pac4j-saml) [WARNING] Bundling transitive dependency java-support-7.5.0.jar (via pac4j-saml) [WARNING] Bundling transitive dependency spymemcached-2.12.3.jar (via pac4j-saml) [WARNING] Bundling transitive dependency httpclient-4.5.3.jar (via pac4j-saml) [WARNING] Bundling transitive dependency httpcore-4.4.8.jar (via pac4j-saml) [WARNING] Bundling transitive dependency xmlsec-2.1.4.jar (via pac4j-saml) [WARNING] Bundling transitive dependency velocity-1.7.jar (via pac4j-saml) [WARNING] Bundling transitive dependency stax2-api-3.1.4.jar (via pac4j-saml) [WARNING] Bundling transitive dependency cryptacular-1.2.4.jar (via pac4j-saml) [WARNING] Bundling transitive dependency jaxb-runtime-2.3.2.jar (via pac4j-saml) [WARNING] Bundling transitive dependency txw2-2.3.2.jar (via pac4j-saml) [WARNING] Bundling transitive dependency javax.json-1.0.4.jar (via pac4j-saml) [WARNING] Bundling transitive dependency stax-ex-1.8.1.jar (via pac4j-saml) [WARNING] Bundling transitive dependency ldaptive-1.0.13.jar (via pac4j-saml) [WARNING] Bundling transitive dependency opensaml-core-3.4.3.jar (via pac4j-saml) [WARNING] Bundling transitive dependency opensaml-messaging-api-3.4.3.jar (via pac4j-saml) [WARNING] Bundling transitive dependency opensaml-messaging-impl-3.4.3.jar (via pac4j-saml) [WARNING] Bundling transitive dependency opensaml-profile-api-3.4.3.jar (via pac4j-saml) [WARNING] Bundling transitive dependency opensaml-profile-impl-3.4.3.jar (via pac4j-saml) [WARNING] Bundling transitive dependency opensaml-saml-api-3.4.3.jar (via pac4j-saml) [WARNING] Bundling transitive dependency opensaml-saml-impl-3.4.3.jar (via pac4j-saml) [WARNING] Bundling transitive dependency opensaml-security-api-3.4.3.jar (via pac4j-saml) [WARNING] Bundling transitive dependency opensaml-security-impl-3.4.3.jar (via pac4j-saml) [WARNING] Bundling transitive dependency opensaml-soap-api-3.4.3.jar (via pac4j-saml) [WARNING] Bundling transitive dependency opensaml-soap-impl-3.4.3.jar (via pac4j-saml) [WARNING] Bundling transitive dependency opensaml-storage-api-3.4.3.jar (via pac4j-saml) [WARNING] Bundling transitive dependency opensaml-storage-impl-3.4.3.jar (via pac4j-saml) [WARNING] Bundling transitive dependency opensaml-xmlsec-api-3.4.3.jar (via pac4j-saml) [WARNING] Bundling transitive dependency opensaml-xmlsec-impl-3.4.3.jar (via pac4j-saml) [WARNING] Bundling transitive dependency pac4j-core-3.9.0.jar (via pac4j-saml)

I will live with the warnings to remove them I have to add more than 300 no-sense lines to the pom to manage these dependencies manually.

Jenkinsfile

Co-authored-by: Jesse Glick <jglick@cloudbees.com>

kuisathaverat · 2020-11-14T13:44:05Z

I have manually tested it, it works. There is a small detail on the URL for the SAML response I have to convert into optional in some way but it works. This is my test environment https://github.com/kuisathaverat/jenkins-issues/tree/master/JENKINS-63350

…into JENKINS-63350

kuisathaverat · 2020-11-15T19:11:38Z

resolved, the plugin works as the previous version works now.

amuniz

INFRA-2809 is resolved and the plugin builds fine locally.

I think this can be merged now @kuisathaverat - thanks for the work here!

amuniz · 2021-02-25T11:17:06Z

Actually, it seems to be downloading the dependency from the shibboleth repo. It's not listed in the Jenkins one. Asked Daniel in the INFRA issue, there seems to be a missing route.

amuniz · 2021-02-25T11:37:08Z

OK, all artifacts are now available in the Jenkins repo, so all good.

pom.xml

kuisathaverat · 2021-02-25T12:26:21Z

I will wait for the CI to finish to merge the PR

timja · 2021-02-25T12:42:35Z

finished ^^

kuisathaverat · 2021-02-25T14:11:19Z

I will release on the weekend

jglick · 2021-02-25T16:39:57Z

Jenkinsfile

@@ -1,15 +1,16 @@
 //def buildConfiguration = buildPlugin.recommendedConfigurations()

-def lts = "2.176.1"
-def weekly = "2.199"
+def lts = "2.249.3"


jglick · 2021-02-25T16:42:04Z

src/main/java/org/jenkinsci/plugins/saml/SamlSecurityRealm.java

-import org.pac4j.core.client.RedirectAction;
-import org.pac4j.core.client.RedirectAction.RedirectType;
+import org.pac4j.core.redirect.RedirectAction;
+import org.pac4j.core.redirect.RedirectAction.RedirectType;
 import org.springframework.dao.DataAccessException;


Do you not plan to switch to Spring Security versions of Jenkins interfaces as well, now that you are on a baseline with JEP-227?

sure, what is the replacement for DataAccessException?

There is none.

Best to look at other PRs associated with JEP-227 for examples.

[JENKINS-63350] update pac4j to 3.8

5786d35

kuisathaverat added the enhancement label Aug 8, 2020

kuisathaverat self-assigned this Aug 8, 2020

add placeholders to compile

68aaa10

jglick reviewed Aug 21, 2020

View reviewed changes

pom.xml Outdated Show resolved Hide resolved

pom.xml Outdated Show resolved Hide resolved

pom.xml Outdated Show resolved Hide resolved

jglick added a commit to jglick/jep that referenced this pull request Aug 21, 2020

Link to jenkinsci/saml-plugin#90

c82b904

rtyler pushed a commit to jglick/jep that referenced this pull request Sep 7, 2020

Link to jenkinsci/saml-plugin#90

bf3a938

kuisathaverat and others added 6 commits November 13, 2020 12:09

chore: remove dummy classes

76b6c1a

feat: update pac4j to 3.9.0 and Jenkins Core to 2.266

ffadcb1

chore: grooming

579a46c

Merge branch 'master' into JENKINS-63350

8ad3af6

fix: maven complain in windows

5188258

fix: compile for the correct version

1beb7e3

jglick reviewed Nov 13, 2020

View reviewed changes

kuisathaverat added 3 commits November 13, 2020 16:12

chore: update incremental maven plugin

81b5bb7

chore: suggested changes on the Jenkinsfile

867faa0

fix: exclude transitive dependencies

e15c310

kuisathaverat changed the title ~~[JENKINS-63350] update pac4j to 3.8~~ [JENKINS-63350] update pac4j to 3.9.0 Nov 13, 2020

kuisathaverat added 2 commits November 13, 2020 17:12

docs: fix javadoc warning

867464d

fix: throw exception

9810e6e

jglick reviewed Nov 13, 2020

View reviewed changes

Jenkinsfile Outdated Show resolved Hide resolved

Jenkinsfile Outdated Show resolved Hide resolved

Apply suggestions from code review

aa2a2f1

Co-authored-by: Jesse Glick <jglick@cloudbees.com>

kuisathaverat added 2 commits November 15, 2020 20:08

fix: ignore parameters in the URL for validation

cb0a8f6

Merge branch 'JENKINS-63350' of github.com:kuisathaverat/saml-plugin …

1b22692

…into JENKINS-63350

amuniz approved these changes Feb 25, 2021

View reviewed changes

kuisathaverat commented Feb 25, 2021

View reviewed changes

pom.xml Outdated Show resolved Hide resolved

Update pom.xml

7c7a310

kuisathaverat marked this pull request as ready for review February 25, 2021 12:25

kuisathaverat merged commit 9f6ed12 into jenkinsci:master Feb 25, 2021

jglick reviewed Feb 25, 2021

View reviewed changes

This was referenced Mar 2, 2021

[JEP-227] Removing mention of saml-plugin#90 jenkinsci/jep#348

Merged

LiveTest, & fix for CCE in SamlSecurityRealm.doFinishLogin #93

Merged

jglick mentioned this pull request Mar 10, 2021

Removing SAMLPluginTest jenkinsci/acceptance-test-harness#652

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[JENKINS-63350] update pac4j to 3.9.0 #90

[JENKINS-63350] update pac4j to 3.9.0 #90

kuisathaverat commented Aug 8, 2020 •

edited

jglick Nov 13, 2020

kuisathaverat Nov 13, 2020

jglick Nov 13, 2020

kuisathaverat Nov 13, 2020

kuisathaverat Nov 13, 2020

jglick Nov 13, 2020

kuisathaverat Nov 13, 2020

kuisathaverat Nov 14, 2020

kuisathaverat commented Nov 14, 2020

kuisathaverat commented Nov 15, 2020 •

edited

amuniz left a comment

amuniz commented Feb 25, 2021 •

edited

amuniz commented Feb 25, 2021

kuisathaverat commented Feb 25, 2021 •

edited

timja commented Feb 25, 2021

kuisathaverat commented Feb 25, 2021

jglick Feb 25, 2021

jglick Feb 25, 2021

kuisathaverat Feb 26, 2021

jglick Feb 26, 2021

[JENKINS-63350] update pac4j to 3.9.0 #90

[JENKINS-63350] update pac4j to 3.9.0 #90

Conversation

kuisathaverat commented Aug 8, 2020 • edited

Submitter checklist

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kuisathaverat commented Nov 14, 2020

kuisathaverat commented Nov 15, 2020 • edited

amuniz left a comment

Choose a reason for hiding this comment

amuniz commented Feb 25, 2021 • edited

amuniz commented Feb 25, 2021

kuisathaverat commented Feb 25, 2021 • edited

timja commented Feb 25, 2021

kuisathaverat commented Feb 25, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kuisathaverat commented Aug 8, 2020 •

edited

kuisathaverat commented Nov 15, 2020 •

edited

amuniz commented Feb 25, 2021 •

edited

kuisathaverat commented Feb 25, 2021 •

edited