-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refresh plugin #291
Refresh plugin #291
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,4 @@ | ||
<?xml version="1.0" encoding="UTF-8"?> | ||
<!-- | ||
|
||
Licensed to Jenkins CI under one or more contributor license | ||
|
@@ -25,7 +26,8 @@ under the License. | |
<parent> | ||
<groupId>org.jenkins-ci.plugins</groupId> | ||
<artifactId>plugin</artifactId> | ||
<version>4.49</version> | ||
<version>4.50</version> | ||
<relativePath /> | ||
</parent> | ||
|
||
<artifactId>saml</artifactId> | ||
|
@@ -35,7 +37,7 @@ under the License. | |
<url>https://github.com/jenkinsci/${project.artifactId}-plugin</url> | ||
|
||
<scm> | ||
<connection>scm:git:git://github.com/${gitHubRepo}.git</connection> | ||
<connection>scm:git:https://github.com/${gitHubRepo}.git</connection> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. GitHub has deprecated |
||
<developerConnection>scm:git:git@github.com:${gitHubRepo}.git</developerConnection> | ||
<url>https://github.com/${gitHubRepo}</url> | ||
<tag>${scmTag}</tag> | ||
|
@@ -219,30 +221,18 @@ under the License. | |
<dependency> | ||
<groupId>org.jenkins-ci.plugins</groupId> | ||
<artifactId>jackson2-api</artifactId> | ||
<version>2.13.4.20221013-295.v8e29ea_354141</version> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Managed in plugin BOM. |
||
</dependency> | ||
<dependency> | ||
<groupId>org.mockito</groupId> | ||
<artifactId>mockito-core</artifactId> | ||
<scope>test</scope> | ||
</dependency> | ||
<dependency> | ||
<groupId>org.hamcrest</groupId> | ||
<artifactId>java-hamcrest</artifactId> | ||
<version>2.0.0.0</version> | ||
<scope>test</scope> | ||
</dependency> | ||
Comment on lines
-229
to
-234
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Managed in plugin parent POM. |
||
<!-- JCasC compatibility --> | ||
<dependency> | ||
<groupId>io.jenkins</groupId> | ||
<artifactId>configuration-as-code</artifactId> | ||
<scope>test</scope> | ||
</dependency> | ||
<dependency> | ||
<groupId>junit</groupId> | ||
<artifactId>junit</artifactId> | ||
<scope>test</scope> | ||
</dependency> | ||
Comment on lines
-241
to
-245
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Managed in plugin parent POM. |
||
<dependency> | ||
<groupId>io.jenkins.configuration-as-code</groupId> | ||
<artifactId>test-harness</artifactId> | ||
|
@@ -274,10 +264,6 @@ under the License. | |
<type>pom</type> | ||
<scope>import</scope> | ||
</dependency> | ||
<dependency> | ||
<groupId>org.cryptacular</groupId> | ||
<artifactId>cryptacular</artifactId> | ||
</dependency> | ||
Comment on lines
-277
to
-280
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. No version number, so dead code. |
||
<dependency> | ||
<groupId>org.apache.santuario</groupId> | ||
<artifactId>xmlsec</artifactId> | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -58,9 +58,6 @@ public static FormValidation checkEmailFormat(String value, String message) { | |
catch (AddressException ae) { | ||
return FormValidation.error(message); | ||
} | ||
catch (NullPointerException ne) { | ||
return FormValidation.warning(message); | ||
} | ||
Comment on lines
-61
to
-63
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This whole method appears to be dead code, but it trips up new versions of SpotBugs. Anyway it does not appear that a |
||
|
||
return FormValidation.ok(); | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consistent with the archetype.