Refresh plugin #291
Merged
Refresh plugin #291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
basil
commented
Nov 12, 2022
| @@ -25,7 +26,8 @@ under the License. | |||
| <parent> | |||
| <groupId>org.jenkins-ci.plugins</groupId> | |||
| <artifactId>plugin</artifactId> | |||
| <version>4.49</version> | |||
| <version>4.50</version> | |||
| <relativePath /> | |||
There was a problem hiding this comment.
Consistent with the archetype.
| @@ -35,7 +37,7 @@ under the License. | |||
| <url>https://github.com/jenkinsci/${project.artifactId}-plugin</url> | |||
|
|
|||
| <scm> | |||
| <connection>scm:git:git://github.com/${gitHubRepo}.git</connection> | |||
| <connection>scm:git:https://github.com/${gitHubRepo}.git</connection> | |||
There was a problem hiding this comment.
GitHub has deprecated git:// URLs.
| @@ -219,30 +221,18 @@ under the License. | |||
| <dependency> | |||
| <groupId>org.jenkins-ci.plugins</groupId> | |||
| <artifactId>jackson2-api</artifactId> | |||
| <version>2.13.4.20221013-295.v8e29ea_354141</version> | |||
Comment on lines
-229
to
-234
| <dependency> | ||
| <groupId>org.hamcrest</groupId> | ||
| <artifactId>java-hamcrest</artifactId> | ||
| <version>2.0.0.0</version> | ||
| <scope>test</scope> | ||
| </dependency> |
There was a problem hiding this comment.
Managed in plugin parent POM.
Comment on lines
-241
to
-245
| <dependency> | ||
| <groupId>junit</groupId> | ||
| <artifactId>junit</artifactId> | ||
| <scope>test</scope> | ||
| </dependency> |
There was a problem hiding this comment.
Managed in plugin parent POM.
Comment on lines
-277
to
-280
| <dependency> | ||
| <groupId>org.cryptacular</groupId> | ||
| <artifactId>cryptacular</artifactId> | ||
| </dependency> |
There was a problem hiding this comment.
No version number, so dead code.
Comment on lines
-61
to
-63
| catch (NullPointerException ne) { | ||
| return FormValidation.warning(message); | ||
| } |
There was a problem hiding this comment.
This whole method appears to be dead code, but it trips up new versions of SpotBugs. Anyway it does not appear that a NullPointerException could actually occur here even if this method was invoked.
kuisathaverat
approved these changes
Nov 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CC @kuisathaverat