Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade the JCasC dependency to 1.35 #122

Merged
merged 1 commit into from
Jan 15, 2020

Conversation

timja
Copy link
Member

@timja timja commented Jan 14, 2020

JCasc had to create a new dependency that wasn't a tests classifier because maven doesn't allow you to bring dependencies through classifiers.

Upgrading here so that PCT works again,

Tracking:
jenkinsci/bom#164

Note: We'll need a release for PCT please

@oleg-nenashev
Copy link
Member

Maybe it is too early to require the new JCasC version @timja

@timja
Copy link
Member Author

timja commented Jan 14, 2020

Maybe it is too early to require the new JCasC version @timja

Why?

@oleg-nenashev
Copy link
Member

Potential breaking changes. When we update to 1.35, I would expect the plugin to also pick up new APIs and to export a proper schema. AFAIK it does not happen now

@timja
Copy link
Member Author

timja commented Jan 14, 2020

Potential breaking changes. When we update to 1.35, I would expect the plugin to also pick up new APIs and to export a proper schema. AFAIK it does not happen now

The tests should cover for breaking changes,

I would expect the plugin to also pick up new APIs and to export a proper schema

Is that a prerequisite for bumping the version? Once it's been upgraded someone could implement a schema for this plugin, note we haven't really looked into what a custom configurator needs to do (if anything)

@oleg-nenashev oleg-nenashev changed the title Upgrade to use jcasc test harness Upgrade JCasC dependency to 1.35 Jan 15, 2020
@oleg-nenashev oleg-nenashev changed the title Upgrade JCasC dependency to 1.35 Upgrade the JCasC dependency to 1.35 Jan 15, 2020
@oleg-nenashev
Copy link
Member

As discussed at the JCasC meeting, I plan to proceed with this update.

@oleg-nenashev oleg-nenashev merged commit 2dd5b92 into jenkinsci:master Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants