Fix typos in metrics doc #662
Conversation
metrics doc contain names with double underscore. Signed-off-by: avlitman <alitman@redhat.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
Markdownlint (reported by Codacy) found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
| | default_jenkins_builds<buildname>_last_build_start_time_milliseconds | Last build start timestamp in milliseconds | gauge | | ||
| | default_jenkins_builds<buildname>_last_build_tests_total | Number of total tests during the last build | gauge | | ||
| | default_jenkins_builds<buildname>_last_last_build_tests_skipped | Number of skipped tests during the last build | gauge | | ||
| | default_jenkins_builds<buildname>_last_build_tests_failing | Number of failing tests during the last build | gauge | |
There was a problem hiding this comment.
The Plugin outputs like default_jenkins_builds_last_build_tests_failing so the _ seems right or am I missing something here?
There was a problem hiding this comment.
I see 2 underscores in the readme , see https://github.com/jenkinsci/prometheus-plugin/blob/master/docs/metrics/index.md
|
@Waschndolos Oh I see you changes it here 304ce25 after I opened this pr.. BTW i still think |
|
Thanks for reaching back. I'll need to test this again - maybe I'm overseeing something here |
|
I'll go ahead and close this PR and fix the documentation in #666 . Guess it's too confusing right now |
metrics doc contain names with double underscore.
Fixes #...
Changes proposed
Checklist
Notify
@Waschndolos