Skip to content

Commit

Permalink
EOL java.level.test (#502)
Browse files Browse the repository at this point in the history
  • Loading branch information
basil committed Feb 16, 2022
1 parent d5601b5 commit 3104328
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 6 deletions.
1 change: 0 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ thought to be overridden are no longer based on properties. The main remaining o
* `hpi-plugin.version`: The HPI Maven Plugin version used by the plugin.
(Generally you should not set this to a version _lower_ than that specified in the parent POM.)
* `stapler-plugin.version`: The Stapler Maven plugin version required by the plugin.
* `java.level.test`: The Java version to use to build the plugin tests.
* In order to make their versions the same as the used core version, `node.version` and `npm.version`
properties are provided.
* Tests are skipped during the `perform` phase of a release (can be overridden by setting `release.skipTests` to false).
Expand Down
8 changes: 3 additions & 5 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -69,9 +69,6 @@
<hpi-plugin.version>3.23</hpi-plugin.version>
<stapler-plugin.version>1.17</stapler-plugin.version>
<java.level>you-must-override-the-java.level-property</java.level>
<!-- Change this property if you need your tests to be compiled with a different Java level than the plugin. -->
<!-- Use only if strictly necessary. It may cause problems in your IDE. -->
<java.level.test>${java.level}</java.level.test>

<!-- Defines a SpotBugs threshold. Use "Low" to discover low-priority bugs.
Hint: SpotBugs considers some real NPE risks in Jenkins as low-priority issues, it is recommended to enable it in plugins.
Expand Down Expand Up @@ -704,8 +701,8 @@
<configuration>
<source>1.${java.level}</source>
<target>1.${java.level}</target>
<testSource>1.${java.level.test}</testSource>
<testTarget>1.${java.level.test}</testTarget>
<testSource>1.${java.level}</testSource>
<testTarget>1.${java.level}</testTarget>
</configuration>
</plugin>
<plugin>
Expand Down Expand Up @@ -967,6 +964,7 @@
<artifactId>maven-compiler-plugin</artifactId>
<configuration>
<release>${java.level}</release>
<testRelease>${java.level}</testRelease>
</configuration>
</plugin>
</plugins>
Expand Down

0 comments on commit 3104328

Please sign in to comment.