Enforce existence of src/main/resources/index.jelly
#302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
basil
approved these changes
Mar 21, 2022
|
Only 4 of the 23 plugins I maintain needed changes. Not bad! |
uhafner
reviewed
Apr 3, 2022
| @@ -133,6 +134,14 @@ private void performPackaging() | |||
| archiver.setArchiver(jarArchiver); | |||
| archiver.setOutputFile(jarFile); | |||
| jarArchiver.addConfiguredManifest(manifest); | |||
| File indexJelly = new File(getClassesDirectory(), "index.jelly"); | |||
| if (!indexJelly.isFile()) { | |||
| throw new MojoFailureException("Missing " + indexJelly + ". Delete any <description> from pom.xml and create src/main/resources/index.jelly:\n" + | |||
There was a problem hiding this comment.
Why do we want to delete the description from the pom? It makes sense to have a description in the pom as well.
There was a problem hiding this comment.
You do not have to delete <description>; it would just be redundant and so there is a chance someone would try to make some text edits expecting them to appear in the product and be confused when they do not.
|
For the record there are 10 plugins affected https://issues.jenkins.io/browse/JENKINS-68300 |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See jenkinsci/junit-attachments-plugin#28 for example.