Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to use jcasc test harness #74

Merged
merged 2 commits into from
Feb 16, 2020
Merged

Conversation

timja
Copy link
Member

@timja timja commented Jan 16, 2020

JCasc had to create a new dependency that wasn't a tests classifier because maven doesn't allow you to bring dependencies through classifiers.

Upgrading here so that PCT works again,

Tracking:
jenkinsci/bom#164

Note: We'll need a release for PCT please

@daniel-beck
Copy link
Member

@timja Could you PTAL at JENKINS-60799 and see why the user claims he only gets 1.32? I'd rather not break even more Docker images with this change.

@timja
Copy link
Member Author

timja commented Jan 24, 2020

JENKINS-60799

I don't understand that issue, install-plugins should install transitive dependencies automatically.

The issue that I could see happening would be users that have pinned configuration-as-code to an old version but updated a plugin that requires a newer version, and the error should be pretty obvious.

Also the issue has no error message to give context, so can't give more information than this really.

@daniel-beck daniel-beck merged commit a847376 into jenkinsci:master Feb 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants