-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added declarative pipeline example #412
Added declarative pipeline example #412
Conversation
Co-authored-by: Mark Waite <mark.earl.waite@gmail.com>
Co-authored-by: Mark Waite <mark.earl.waite@gmail.com>
Co-authored-by: Mark Waite <mark.earl.waite@gmail.com>
Co-authored-by: Mark Waite <mark.earl.waite@gmail.com>
Co-authored-by: Mark Waite <mark.earl.waite@gmail.com>
Co-authored-by: Mark Waite <mark.earl.waite@gmail.com>
Co-authored-by: Mark Waite <mark.earl.waite@gmail.com>
Co-authored-by: Mark Waite <mark.earl.waite@gmail.com>
Co-authored-by: Mark Waite <mark.earl.waite@gmail.com>
Co-authored-by: Mark Waite <mark.earl.waite@gmail.com>
Co-authored-by: Martin Pokorny <89339813+mPokornyETM@users.noreply.github.com>
As noted on Gitter, I think it makes better sense to not convert (replace) existing examples, but to really "Add" as in the title, and clearly mark "Example for scripted pipeline" vs. "Example for declarative pipeline". Both dialects are actively used, as different tools for different jobs. Also, try to constrain the initial PR to focus on its feature changes. Seems it currently includes a version of commits already merged (or proposed elsewhere) to master and they show up in https://github.com/jenkinsci/lockable-resources-plugin/pull/412/files as changes for review: git-rebasing over current upstream/master can help. |
…github.com/Jagrutiti/lockable-resources-plugin into declarative-pipeline-syntax-to-readme-file
Hey @jimklimov I have added your suggestions and re-based the commit to master. |
Thanks for the rebase, still the "Changes" look odd. Was |
When I am correct , this branch was created from |
I propose to wait for this PR #403 and then re-merge master to this branch. After them you will see real changes. |
Hey @mPokornyETM , @jimklimov I had created my branch from I wanted you guys to confirm:
|
Thx I will wait until #403 is merged. Then it will be easier to review the changes. Pls wait next 1 or 2 days and I give you here a feedback. Thx |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Close #322
Testing done
NN
Proposed upgrade guidelines
N/A
Localizations
Submitter checklist
Maintainer checklist
Before the changes are marked as
ready-for-merge
: