Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more examples #403

Merged
merged 22 commits into from Nov 27, 2022
Merged

Add more examples #403

merged 22 commits into from Nov 27, 2022

Conversation

mPokornyETM
Copy link
Contributor

@mPokornyETM mPokornyETM commented Nov 20, 2022

Closes #44
Closes #56
Closes #58

Testing done

There are no new tests necessary because only documentation has been updated.

Proposed changelog entries

  • Document node dependent resources
  • Document declarative Pipeline use
  • Document resource name and resource label use

Proposed upgrade guidelines

N/A

Localizations

  • English
    Other languages must be done in Crowdin after this PR is merge into master (There is still open Improve translations #396 and it will leads to merge conflicts again :-( )

Submitter checklist

  • The Jira / Github issue, if it exists, is well-described.
  • The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples).
    • Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during the upgrade.
  • There is automated testing or an explanation that explains why this change has no tests.
  • [ ] New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
  • [ ] New public functions for internal use only are annotated with @NoExternalUse. In case it is used by non java code the Used by {@code <panel>.jelly} Javadocs are annotated.
  • [ ] New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
  • [ ] New or substantially changed JavaScript is not defined inline and does not call eval to ease the future introduction of Content Security Policy (CSP) directives (see documentation).
  • [ ] For dependency updates, there are links to external changelogs and, if possible, full differentials.
  • [ ] For new APIs and extension points, there is a link to at least one consumer.
  • Any localizations are transferred to *.properties files.
    As described it can be done after merge.

Maintainer checklist

Before the changes are marked as ready-for-merge:

  • There is at least one (1) approval for the pull request and no outstanding requests for change.
  • Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
  • Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
  • Proper changelog labels are set so that the changelog can be generated automatically.
  • If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
  • java code changes are tested by automated test.

mPokornyETM and others added 17 commits November 20, 2022 21:21
Co-authored-by: Mark Waite <mark.earl.waite@gmail.com>
Co-authored-by: Mark Waite <mark.earl.waite@gmail.com>
Co-authored-by: Mark Waite <mark.earl.waite@gmail.com>
Co-authored-by: Mark Waite <mark.earl.waite@gmail.com>
Co-authored-by: Mark Waite <mark.earl.waite@gmail.com>
Co-authored-by: Mark Waite <mark.earl.waite@gmail.com>
Co-authored-by: Mark Waite <mark.earl.waite@gmail.com>
Co-authored-by: Mark Waite <mark.earl.waite@gmail.com>
Co-authored-by: Mark Waite <mark.earl.waite@gmail.com>
Co-authored-by: Mark Waite <mark.earl.waite@gmail.com>
@mPokornyETM

This comment was marked as off-topic.

Jagrutiti and others added 3 commits November 21, 2022 18:04
Co-authored-by: Martin Pokorny <89339813+mPokornyETM@users.noreply.github.com>
@mPokornyETM mPokornyETM marked this pull request as ready for review November 23, 2022 21:16
@mPokornyETM mPokornyETM requested a review from a team as a code owner November 23, 2022 21:16
@mPokornyETM mPokornyETM enabled auto-merge (squash) November 23, 2022 21:25
@mPokornyETM mPokornyETM mentioned this pull request Nov 24, 2022
10 tasks
@mPokornyETM
Copy link
Contributor Author

When nobody request a change or leave comment here I will merge it in 24 hours

@mPokornyETM mPokornyETM merged commit 7a87199 into master Nov 27, 2022
@mPokornyETM mPokornyETM deleted the extend-documentation branch November 27, 2022 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants