Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-46076] Hoping that workflow-job-plugin #131 will fix a flake in PodTemplateStepExecutionTest.testBadLabel #496

Merged
merged 6 commits into from
Jun 27, 2019

Conversation

jglick
Copy link
Member

@jglick jglick commented Jun 10, 2019

Downstream of jenkinsci/workflow-job-plugin#131. Supersedes an attempt made in #490. @Vlatombe

Verified

This commit was signed with the committer’s verified signature.
jglick Jesse Glick
…x a flake in PodTemplateStepExecutionTest.testBadLabel.

Verified

This commit was signed with the committer’s verified signature.
jglick Jesse Glick
…complete log file; need to use waitForMessage (→ isLogUpdated).

Verified

This commit was signed with the committer’s verified signature.
jglick Jesse Glick
jglick added a commit to jglick/kubernetes-plugin that referenced this pull request Jun 11, 2019

Verified

This commit was signed with the committer’s verified signature.
jglick Jesse Glick
jglick added 2 commits June 12, 2019 11:48

Verified

This commit was signed with the committer’s verified signature.
jglick Jesse Glick

Verified

This commit was signed with the committer’s verified signature.
jglick Jesse Glick

Partially verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
We cannot verify signatures from co-authors, and some of the co-authors attributed to this commit require their commits to be signed.
Co-Authored-By: Devin Nusbaum <dwnusbaum@users.noreply.github.com>
@jglick jglick removed the on hold label Jun 27, 2019
@jglick jglick requested a review from Vlatombe June 27, 2019 18:21
Copy link
Member

@Vlatombe Vlatombe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Waiting for the build completion before merging

@Vlatombe Vlatombe merged commit f727c0b into jenkinsci:master Jun 27, 2019
@jglick jglick deleted the finish-JENKINS-46076 branch June 27, 2019 18:59
jglick added a commit to jglick/kubernetes-plugin that referenced this pull request Jul 5, 2019

Verified

This commit was signed with the committer’s verified signature.
jglick Jesse Glick
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants