Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-73103] Prepare plugin to allow users with overall/manage to manage clouds/pod/container templates #1546

Merged
merged 7 commits into from May 21, 2024

Conversation

mikecirioli
Copy link
Contributor

@mikecirioli mikecirioli commented May 7, 2024

JENKINS-73103

Initial work to allow users with Overall/Manage to configure clouds (and pod/container templates). This PR is focused on adding Overall/Manage support for kubernetes clouds and pod templates. A separate PR against jenkins core is needed in order to make the clouds management-link visible.

Testing done

Submitter checklist

Edit tasklist title
Beta Give feedback Tasklist Submitter checklist, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
    Options
  2. Ensure that the pull request title represents the desired changelog entry
    Options
  3. Please describe what you did
    Options
  4. Link to relevant issues in GitHub or Jira
    Options
  5. Link to relevant pull requests, esp. upstream and downstream changes
    Options
  6. Ensure you have provided tests - that demonstrates feature works or fixes the issue
    Options

@mikecirioli mikecirioli requested a review from a team as a code owner May 7, 2024 12:20
@mikecirioli mikecirioli marked this pull request as draft May 7, 2024 12:20
@mikecirioli mikecirioli changed the title [JENKINS-73103] allow overall/manage to edit/save pod templates [JENKINS-73103] allow overall/manage to manage clouds/pod/container templates May 7, 2024
@mikecirioli mikecirioli changed the title [JENKINS-73103] allow overall/manage to manage clouds/pod/container templates [JENKINS-73103] Prepare plugin to allow users with overall/manage to manage clouds/pod/container templates May 8, 2024
@Vlatombe
Copy link
Member

Relevant CI failure

Caused by: org.xml.sax.SAXParseException; systemId: file:/home/jenkins/agent/workspace/lugins_kubernetes-plugin_PR-1546/target/classes/org/csanchez/jenkins/plugins/kubernetes/KubernetesCloud/new.jelly; lineNumber: 39; columnNumber: 33; The prefix ":l" for element ":l:hasAdministerOrManage" is not bound.
	at java.xml/com.sun.org.apache.xerces.internal.util.ErrorHandlerWrapper.createSAXParseException(ErrorHandlerWrapper.java:204)

@mikecirioli mikecirioli marked this pull request as ready for review May 16, 2024 15:47
@Vlatombe Vlatombe added the enhancement Improvements label May 21, 2024
@Vlatombe Vlatombe merged commit ceef11c into jenkinsci:master May 21, 2024
6 checks passed
@amuniz
Copy link
Member

amuniz commented May 21, 2024

A separate PR against jenkins core is needed in order to make the clouds management-link visible

Was this not needed finally?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvements
Projects
None yet
4 participants