Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove <optional> from config-file-provider dependency #1414

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

strangelookingnerd
Copy link
Contributor

Remove the optional flag from the config-file-provider dependency.
To my understanding this dependency is directly referenced in ExecuteDslScripts as well as JenkinsDslScriptLoader and for that reason should not be optional.

Resolves jenkinsci/custom-folder-icon-plugin#280

Testing done

Ran existing tests without any errors.

Submitter checklist

Edit tasklist title
Beta Give feedback Tasklist Submitter checklist, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
    Options
  2. Ensure that the pull request title represents the desired changelog entry
    Options
  3. Please describe what you did
    Options
  4. Link to relevant issues in GitHub or Jira
    Options
  5. Link to relevant pull requests, esp. upstream and downstream changes
    Options
  6. Ensure you have provided tests - that demonstrates feature works or fixes the issue
    Options

@strangelookingnerd strangelookingnerd requested a review from a team as a code owner January 8, 2024 11:42
@strangelookingnerd strangelookingnerd force-pushed the bugfix/config-file-provider_not_optional branch from 77e4d79 to ebaec6e Compare April 17, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant