Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gerrit Event Trigger - Add Private & WIP State changed #1262

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zeralight
Copy link

@zeralight zeralight commented Dec 15, 2022

Since Gerrit 2.15, new events hooks have been introduced which can be used to trigger new Builds:

  • Private state changed
  • Work In Progress state changed
  • Draft Publication removed

Ref: https://www.gerritcodereview.com/2.15.html#new-workflows

In this PR, we add support for the new events and keep the removed one for compatibility with Gerrit < 2.15.

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

Copy link
Member

@basil basil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The argument to the @since tag refers to the version of this repository, not the version of some other repository; 2.15 is not a valid version of Job DSL.

Why are the methods of GerritEventContext not kept sorted in lexicographical order?

Why is this PR not in draft state when TriggerContextSpec is consistently failing?

Speaking of tests, how was this PR tested?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants