Fix: Don't destroy credentials when re-creating organization folder #1248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like some tests are failing. I looked at them for a while but can't understand why. I would be happy to continue debugging if someone has some pointers. |
Extend the current code which does it for cloudbee Folder to Organization Folder. refs JENKINS-44681 jenkinsci#1232
jfroche
force-pushed
the
fix/merge-credentials-on-organization-folder
branch
from
2c94ecc
to
3fd5af2
Compare
|
Hey thanks for raising this! I'm happy finishing this off, as I've got it mostly working locally, are you happy me pushing to this branch and keeping you as a contributor, or shall I raise a separate PR? |
|
thank you ! do no hesitate for force push here |
|
Sorry for the late reply, I've just picked this up again. I've got the core code changes done, but seeing an issue due to:
|
6 tasks
|
Moving to #1251, thanks for the work on this 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend the current code which does it for cloudbee Folder to Organization Folder.
refs JENKINS-44681
Previous fix for cloudbee Folder: #1232