Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update jenkinsfile-runner-launcher #613

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update jenkinsfile-runner-launcher #613

wants to merge 1 commit into from

Conversation

vijaypitla
Copy link

@vijaypitla vijaypitla commented Mar 31, 2022 •
edited

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@vijaypitla vijaypitla requested a review from a team as a code owner March 31, 2022 18:19
@vijaypitla vijaypitla closed this Mar 31, 2022
@vijaypitla
Copy link
Author

Pls approve

@vijaypitla vijaypitla reopened this Mar 31, 2022
oleg-nenashev
oleg-nenashev requested changes Apr 14, 2022
View reviewed changes
Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This change needs to be reflected in documentation. Also, please make sure the pull request title is explicit about what you are trying to achieve

@oleg-nenashev
Copy link
Member

@vijaypitla are you still interested in having it merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oleg-nenashev oleg-nenashev oleg-nenashev requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vijaypitla @oleg-nenashev