Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary references in allowed classes list #9265

Merged
merged 1 commit into from May 13, 2024
Merged

Remove unnecessary references in allowed classes list #9265

merged 1 commit into from May 13, 2024

Conversation

basil
Copy link
Member

@basil basil commented May 12, 2024 •
edited

As far as I can tell, these references were only needed to get QueueTest#fileItemPersistence to pass, but that test was a contrived/artificial scenario and was deleted in #9260. As explained in that PR, DiskFileItem hasn't actually been serialized to disk in practice since 2012, and since 1.3.3 can DiskFileItem can no longer be deserialized for security reasons. As such, these references are dead code and can simply be deleted.

Testing done

CI build and PCT in jenkinsci/bom#3195.

Proposed changelog entries

N/A

Proposed upgrade guidelines

N/A

Submitter checklist

Edit tasklist title
Beta Give feedback Tasklist Submitter checklist, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. The Jira issue, if it exists, is well-described.
    Options
  2. The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples). Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
    Options
  3. There is automated testing or an explanation as to why this change has no tests.
    Options
  4. New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
    Options
  5. New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
    Options
  6. New or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
    Options
  7. For dependency updates, there are links to external changelogs and, if possible, full differentials.
    Options
  8. For new APIs and extension points, there is a link to at least one consumer.
    Options

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

Edit tasklist title
Beta Give feedback Tasklist Maintainer checklist, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. There are at least two (2) approvals for the pull request and no outstanding requests for change.
    Options
  2. Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
    Options
  3. Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
    Options
  4. Proper changelog labels are set so that the changelog can be generated automatically.
    Options
  5. If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
    Options
  6. If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).
    Options

@basil basil added the work-in-progress The PR is under active development, not ready to the final review label May 12, 2024
basil added a commit to basil/bom that referenced this pull request May 13, 2024
@basil
Test jenkinsci/jenkins#9265
7630e04
@basil basil added skip-changelog Should not be shown in the changelog and removed work-in-progress The PR is under active development, not ready to the final review labels May 13, 2024
@basil basil marked this pull request as ready for review May 13, 2024 17:08
@basil basil requested review from MarkEWaite and timja May 13, 2024 17:34
@MarkEWaite MarkEWaite changed the title Remove unnecessary reference Remove unnecessary reference in allowed classes list May 13, 2024
@MarkEWaite
Copy link
Contributor

This PR is now ready for merge. We will merge it after approximately 24 hours if there is no negative feedback.

/label ready-for-merge

@comment-ops-bot comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label May 13, 2024
@MarkEWaite MarkEWaite changed the title Remove unnecessary reference in allowed classes list Remove unnecessary references in allowed classes list May 13, 2024
@basil
Copy link
Member Author

basil commented May 13, 2024

I've got another PR that depends on this one, so let's merge this PR now to unblock the other one.

@basil basil merged commit 6371bc1 into jenkinsci:master May 13, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarkEWaite MarkEWaite MarkEWaite approved these changes

@NotMyFault NotMyFault NotMyFault approved these changes

@timja timja Awaiting requested review from timja

Assignees
No one assigned
Labels
ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback skip-changelog Should not be shown in the changelog
Projects
None yet
Milestone
No milestone
3 participants
@basil @MarkEWaite @NotMyFault