New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite the build history widget #9148
base: master
Are you sure you want to change the base?
Conversation
commit 1ce4cb3 Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com> Date: Tue Apr 9 09:22:36 2024 +0100 Rename classes commit 107d794 Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com> Date: Tue Apr 9 08:59:54 2024 +0100 Update HistoryWidget.java commit 13575bc Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com> Date: Tue Apr 9 08:59:29 2024 +0100 Hide buttons commit e5de546 Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com> Date: Tue Apr 9 08:39:04 2024 +0100 Rename classes commit 47c84af Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com> Date: Mon Apr 8 23:21:36 2024 +0100 Add animation commit e7432b6 Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com> Date: Mon Apr 8 23:03:19 2024 +0100 Add navigation buttons commit 448a094 Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com> Date: Mon Apr 8 22:29:32 2024 +0100 Update _dashboard.scss commit bb85734 Merge: c451a72 27433f1 Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com> Date: Mon Apr 8 22:23:38 2024 +0100 Merge branch 'master' into new-build-history-2 commit c451a72 Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com> Date: Mon Apr 8 13:17:05 2024 +0100 Update _job.scss commit 960b162 Merge: d020eb6 af655e3 Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com> Date: Mon Apr 8 13:16:54 2024 +0100 Merge branch 'remove-table-usage' into new-build-history-2 commit af655e3 Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com> Date: Mon Apr 8 13:13:38 2024 +0100 Init commit d020eb6 Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com> Date: Mon Apr 8 13:09:57 2024 +0100 Update card.jelly commit 81bc1d4 Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com> Date: Mon Apr 8 13:07:41 2024 +0100 Update _buttons.scss commit 4023460 Merge: 875fb8f da5f593 Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com> Date: Mon Apr 8 13:03:18 2024 +0100 Merge branch 'master' into new-build-history-2 commit 875fb8f Merge: 2dc9964 fe60fac Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com> Date: Sat Apr 6 19:29:20 2024 +0100 Merge branch 'master' into new-build-history-2 commit 2dc9964 Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com> Date: Fri Apr 5 22:17:08 2024 +0100 Reset files commit 2da1e14 Merge: dce466a b9fac75 Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com> Date: Fri Apr 5 22:14:46 2024 +0100 Merge branch 'master' into new-build-history-2 commit dce466a Merge: 935c16e 0eed048 Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com> Date: Wed Feb 28 13:55:35 2024 +0000 Merge branch 'master' into new-build-history-2 commit 935c16e Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com> Date: Sun Feb 18 17:54:32 2024 +0000 Update entry.jelly commit 2a19a04 Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com> Date: Sun Feb 18 17:51:58 2024 +0000 Rename classes commit 3ef46ab Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com> Date: Sun Feb 18 17:29:25 2024 +0000 Update index.jelly commit da0b212 Merge: 281fac0 9d9e2ab Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com> Date: Sun Feb 18 17:27:12 2024 +0000 Merge branch 'revamp-dropdowns' into new-build-history-2 commit 281fac0 Merge: 9c69bd0 a642354 Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com> Date: Sun Feb 18 17:19:14 2024 +0000 Merge branch 'master' into new-build-history-2 commit 9d9e2ab Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com> Date: Sat Feb 10 19:39:24 2024 +0000 Update templates.js commit 1c19e43 Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com> Date: Sat Feb 10 19:38:13 2024 +0000 Add clazz commit 8b944e9 Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com> Date: Sat Feb 10 15:19:30 2024 +0000 Update utils.js commit 069fefb Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com> Date: Sat Feb 10 13:23:16 2024 +0000 Linting commit 7270712 Merge: 9865811 a642354 Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com> Date: Sat Feb 10 12:20:02 2024 +0000 Merge branch 'master' into revamp-dropdowns commit 9865811 Merge: 1e22c34 86d39dd Author: Mark Waite <mark.earl.waite@gmail.com> Date: Thu Jan 18 05:39:13 2024 -0700 Merge branch 'master' into revamp-dropdowns commit 9c69bd0 Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com> Date: Sun Jan 14 13:56:49 2024 +0000 Push commit 347e966 Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com> Date: Sun Jan 14 13:53:52 2024 +0000 Update filter-build-history.js commit 0b4a5dd Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com> Date: Sun Jan 14 13:49:54 2024 +0000 Renam commit a8277bf Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com> Date: Sun Jan 14 13:46:53 2024 +0000 Fix commit 855bf13 Merge: 61b0a87 1eb29a8 Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com> Date: Sun Jan 14 13:38:51 2024 +0000 Merge branch 'master' into new-build-history-2 commit 1e22c34 Merge: 44981c2 48661db Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com> Date: Sun Jan 14 13:33:14 2024 +0000 Merge branch 'master' into revamp-dropdowns commit 44981c2 Merge: 0075375 1eb29a8 Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com> Date: Mon Jan 8 21:14:51 2024 +0000 Merge branch 'master' into revamp-dropdowns commit 0075375 Merge: 2dd9e32 78cdaa9 Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com> Date: Thu Jan 4 13:26:24 2024 +0000 Merge branch 'master' into revamp-dropdowns commit 2dd9e32 Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com> Date: Thu Jan 4 13:24:53 2024 +0000 Remove translations commit 6800c88 Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com> Date: Thu Jan 4 13:16:19 2024 +0000 Update header.jelly commit 1c3961b Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com> Date: Thu Jan 4 13:15:49 2024 +0000 Add additional docs commit 163be52 Merge: 4cc43e4 444f2de Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com> Date: Wed Jan 3 21:22:20 2024 +0000 Merge branch 'master' into revamp-dropdowns commit 61b0a87 Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com> Date: Thu Dec 14 19:38:45 2023 +0000 More commit dcd6aaa Merge: 0c40b9f edce488 Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com> Date: Thu Dec 14 19:38:25 2023 +0000 Merge branch 'stop-button' into new-build-history-2 commit edce488 Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com> Date: Thu Dec 14 16:06:00 2023 +0000 Tidy up commit 157ba0b Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com> Date: Thu Dec 14 16:04:46 2023 +0000 Fix i18n commit a112bd9 Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com> Date: Wed Dec 13 22:57:17 2023 +0000 Update _buttons.scss commit 91751cf Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com> Date: Wed Dec 13 22:39:18 2023 +0000 Update executors.jelly commit cd89aea Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com> Date: Wed Dec 13 22:31:06 2023 +0000 Fixes commit 1384091 Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com> Date: Wed Dec 13 22:28:54 2023 +0000 Init commit 0c40b9f Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com> Date: Wed Dec 13 16:50:53 2023 +0000 Update _buttons.scss commit 50fe8fc Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com> Date: Wed Dec 13 13:13:10 2023 +0000 add view transitions commit d1fd7a9 Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com> Date: Tue Dec 12 20:25:44 2023 +0000 Tidy up commit 512b9a1 Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com> Date: Tue Dec 12 19:29:16 2023 +0000 Push commit 4f15690 Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com> Date: Mon Dec 11 23:30:09 2023 +0000 push commit ad75b0f Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com> Date: Mon Dec 11 23:24:11 2023 +0000 Update _buttons.scss commit cec222e Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com> Date: Mon Dec 11 23:23:52 2023 +0000 Update _buttons.scss commit 4cc43e4 Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com> Date: Sun Dec 10 16:04:28 2023 +0000 Add docs commit a4c7f4f Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com> Date: Sun Dec 10 16:00:23 2023 +0000 Update taglib commit c01db44 Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com> Date: Sun Dec 10 15:56:50 2023 +0000 Init commit 21bb3f4 Merge: d3e2920 428d0e5 Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com> Date: Sun Dec 10 13:22:00 2023 +0000 Merge branch 'restyle-cards' into new-build-history-2 commit 428d0e5 Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com> Date: Thu Dec 7 20:17:10 2023 +0000 Lower weight commit ac5c255 Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com> Date: Thu Dec 7 20:15:28 2023 +0000 Remove more bold weights commit 2922a69 Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com> Date: Thu Dec 7 20:11:33 2023 +0000 Update _style.scss commit 9657d46 Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com> Date: Thu Dec 7 20:06:16 2023 +0000 Init commit d3e2920 Merge: a2bd9a0 cabc8f6 Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com> Date: Thu Dec 7 19:50:43 2023 +0000 Merge branch 'master' into new-build-history-2 commit a2bd9a0 Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com> Date: Sun Nov 26 11:58:22 2023 +0000 Fixes commit 7cda504 Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com> Date: Sat Nov 25 12:28:04 2023 +0000 Working build commit abd994e Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com> Date: Sat Nov 25 11:58:42 2023 +0000 Working build commit 9b6defb Merge: 29fcb64 7a0e57e Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com> Date: Sat Nov 25 11:51:24 2023 +0000 Merge branch 'progress-bar-new' into new-build-history-2 commit 29fcb64 Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com> Date: Sat Nov 25 11:51:10 2023 +0000 More commit 2f946d3 Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com> Date: Sat Nov 25 09:17:06 2023 +0000 Update _buttons.scss commit f5474b3 Merge: 00c3879 982bc48 Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com> Date: Sat Nov 25 09:16:14 2023 +0000 Merge branch 'use-symbols-for-build-status-new' into new-build-history-2 commit 982bc48 Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com> Date: Sat Nov 25 09:15:56 2023 +0000 Fix app bar build status icon being incorrect commit 00c3879 Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com> Date: Sat Nov 25 09:12:10 2023 +0000 Fixes commit a4960e9 Merge: d28aada c6f5db0 Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com> Date: Sat Nov 25 08:56:01 2023 +0000 Merge branch 'use-symbols-for-build-status-new' into new-build-history-2 commit d28aada Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com> Date: Sat Nov 25 08:55:18 2023 +0000 Update _buttons.scss commit 1d24a19 Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com> Date: Sat Nov 25 08:52:58 2023 +0000 Init commit 7a0e57e Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com> Date: Fri Nov 24 21:19:23 2023 +0000 More commit 67d4264 Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com> Date: Fri Nov 24 21:17:09 2023 +0000 Update _spinner.scss commit 9befc76 Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com> Date: Fri Nov 24 21:07:55 2023 +0000 Update _spinner.scss commit 528b46a Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com> Date: Fri Nov 24 21:01:06 2023 +0000 More commit ea0c487 Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com> Date: Fri Nov 24 20:36:53 2023 +0000 Init commit c6f5db0 Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com> Date: Fri Nov 24 17:52:28 2023 +0000 Fix icon position commit 18a8407 Merge: aea4d97 a9c34d7 Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com> Date: Fri Nov 24 09:58:54 2023 +0000 Merge branch 'master' into use-symbols-for-build-status-new commit aea4d97 Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com> Date: Fri Nov 24 09:58:29 2023 +0000 Rename ID commit 5f76f38 Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com> Date: Mon Nov 20 16:00:14 2023 +0000 Init
can you add before screenshots too please |
What made the previous implementation so big was the logic to find a suitable way to arrange all the things. See #9122 for my PR that changed they calculation to be more efficient. |
Please take a moment and address the merge conflicts of your pull request. Thanks! |
Getting |
I see the issue, PR incoming |
core/src/main/resources/hudson/widgets/HistoryWidget/index.jelly
Outdated
Show resolved
Hide resolved
core/src/main/resources/hudson/widgets/HistoryWidget/index.jelly
Outdated
Show resolved
Hide resolved
core/src/main/resources/hudson/widgets/HistoryWidget/entry.jelly
Outdated
Show resolved
Hide resolved
core/src/main/resources/hudson/widgets/HistoryWidget/entry.jelly
Outdated
Show resolved
Hide resolved
margin-top: 0.385rem; | ||
|
||
svg { | ||
width: 1.25rem; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes the status icon 20x20, before it was 16x16. Is this intentional?
The badges stay with 16x16
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think so, think the status icon is the most important icon overall so doesn't hurt to be a touch larger.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FWIW the icons in badges of course can be bigger but really shouldn’t because they won’t align with the text height anymore. The latter is also the case with the build status icon being 20x20. I just found it odd that they became bigger (jenkinsci/badge-plugin#151 (comment))
I'm not able to reproduce the badge overflowing, but having many badges with icons from Badge plugin leads to the icons getting very small. Probably also an issue with the badge plugin itself. But ideally the badges would start flowing in the next row. Seems with the refactoring of the badge plugin things do indeed overflow. |
I just copied the examples for symbols from the pipeline syntax page and repeated twice in addBadge
|
I added |
This PR implements the changes discussed https://community.jenkins.io/t/revamped-build-history-widget/10944. In essence it's a rewrite/redesign of the build history widget. The goal is to be cleaner and simpler, whilst still retaining existing functionality and density.
Before
After
What's changed
What doesn't work
Pagination controls are always visible at the momentThe list doesn't auto refresh at the momentItems with long names/lots of actions don't scale very wellTesting done
Proposed changelog entries
Proposed upgrade guidelines
N/A
Submitter checklist
@Restricted
or have@since TODO
Javadocs, as appropriate.@Deprecated(since = "TODO")
or@Deprecated(forRemoval = true, since = "TODO")
, if applicable.eval
to ease future introduction of Content Security Policy (CSP) directives (see documentation).Desired reviewers
@jenkinsci/sig-ux
Before the changes are marked as
ready-for-merge
:Maintainer checklist
upgrade-guide-needed
label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).lts-candidate
to be considered (see query).